Rename USPS classes to GPO (LG-4233)#4837
Merged
zachmargolis merged 9 commits intomainfrom Mar 25, 2021
Merged
Conversation
**Why**: To differentiate from USPS in-person proofing
mitchellhenke
approved these changes
Mar 25, 2021
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Kudos on all of the work to rename all of these
It looks like all of this is already backward-compatible too 👏🏼 👏🏼
zachmargolis
added a commit
that referenced
this pull request
Mar 25, 2021
**Why**: This needs to be deployed after #4837 has been out in production
zachmargolis
added a commit
that referenced
this pull request
Mar 31, 2021
zachmargolis
added a commit
that referenced
this pull request
Mar 31, 2021
zachmargolis
added a commit
that referenced
this pull request
Apr 9, 2021
**Why**: This needs to be deployed after #4837 has been out in production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To differentiate from USPS in-person proofing
I renamed as much as I could, but left a few things: