Stop referencing ServiceProvider#fingerprint#4884
Merged
zachmargolis merged 1 commit intomainfrom Apr 6, 2021
Merged
Conversation
Contributor
Author
|
Whoops, I didn't see #4877 |
Contributor
|
#4877 only covered the seed file, so we could keep the rest of the proposed changes. |
mitchellhenke
approved these changes
Apr 6, 2021
Merged
zachmargolis
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Revert "Ensure non-nil fingerprint for SAML logout (#4890)" This reverts commit 00deec6. * Revert "Stop referencing ServiceProvider#fingerprint (#4884)" This reverts commit 7fe7be7. * Revert "Remove fingerprint from seeded local development service provider (#4877)" This reverts commit a8c9481. * Revert "Allow SPs to have multiple certs (LG-2049) (#4851)" This reverts commit 0efa17f. * Restore migration from multi-cert * Re-add certs column to NullServiceProvider
aduth
added a commit
that referenced
this pull request
Apr 8, 2021
* Revert "Ensure non-nil fingerprint for SAML logout (#4890)" This reverts commit 00deec6. * Revert "Stop referencing ServiceProvider#fingerprint (#4884)" This reverts commit 7fe7be7. * Revert "Remove fingerprint from seeded local development service provider (#4877)" This reverts commit a8c9481. * Revert "Allow SPs to have multiple certs (LG-2049) (#4851)" This reverts commit 0efa17f. * Restore migration from multi-cert * Re-add certs column to NullServiceProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4851 (comment)