Remove circa-2019 in-person proofing prototype flow#4852
Conversation
**Why**: It is disabled in all environments including local development, and its continued existence has proven to be an unnecessary maintenance burden. See: - #3042 - https://github.com/18F/identity-idp/commits/main/app/views/idv/in_person
| encryption_error: 2, | ||
| verification_pending: 3, | ||
| verification_cancelled: 4, | ||
| in_person_pending: 5, |
There was a problem hiding this comment.
I think we should leave this just in case there is existing data out there, maybe rename it to _deprecated or something? But the risk of a collision when we do have a new event 5 make me hesitate
There was a problem hiding this comment.
I think we should leave this just in case there is existing data out there, maybe rename it to
_deprecatedor something? But the risk of a collision when we do have a new event 5 make me hesitate
Yeah, we could. But since this was never enabled, maybe we could just confirm there's no instances of it in deployed environments, then be okay to just remove it altogether?
There was a problem hiding this comment.
Looks like prod, staging and int are clear:
Profile.where(deactivation_reason: :in_person_pending).first
# niland to check that the syntax/encoding was correct, this returned results:
Profile.where(deactivation_reason: :password_reset).firstThere was a problem hiding this comment.
I checked dev as well, nothing there either.
I assume we're good to remove it outright?
There was a problem hiding this comment.
Yup, should be good to remove
2 participants
Why: It is disabled in all environments including local development, and its continued existence has proven to be an unnecessary maintenance burden.
See: