LG-4327 First pass image metric errors for DPI, Blur, and Glare#4882
Merged
amathews-fs merged 5 commits intomainfrom Apr 7, 2021
Merged
LG-4327 First pass image metric errors for DPI, Blur, and Glare#4882amathews-fs merged 5 commits intomainfrom
amathews-fs merged 5 commits intomainfrom
Conversation
amathews-fs
commented
Apr 5, 2021
| gem 'hiredis' | ||
| gem 'http_accept_language' | ||
| gem 'identity-doc-auth', github: '18F/identity-doc-auth', branch: 'v0.5.0' | ||
| gem 'identity-doc-auth', github: '18F/identity-doc-auth', tag: 'v0.5.1' |
Contributor
Author
There was a problem hiding this comment.
@zachmargolis what was the reason we switched from tag to branch here? I switched it back because that's what we'd been doing but I wanted to check.
Contributor
There was a problem hiding this comment.
It should be tag , branch was likely a development mistake from me 🤦
Contributor
Author
There was a problem hiding this comment.
No problem! I'll merge the gem shortly and tag the new release. 😄
solipet
approved these changes
Apr 6, 2021
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
lgtm - just don't forget the Gemfile.lock ;-)
…e Gemfile.lock with the new doc-auth gem release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the first pass at doc auth errors for problems with the image metrics Acuant returns. There will be a significant refactor for the error handling coming next.
Associated with this PR in Identity-doc-auth gem
Note: The gemfile.lock has not been updated because the gem code has not yet been merged and tagged. That must happen before merging this.