Skip to content

LG-4331 Add coverage for upload step on desktop and mobile devices#4863

Merged
stevegsa merged 1 commit intomainfrom
stevegsa-test-upload-step
Apr 2, 2021
Merged

LG-4331 Add coverage for upload step on desktop and mobile devices#4863
stevegsa merged 1 commit intomainfrom
stevegsa-test-upload-step

Conversation

@stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Apr 2, 2021

No description provided.

@stevegsa stevegsa marked this pull request as ready for review April 2, 2021 03:15
aduth
aduth approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this would catch a regression of a revert of #4774 👍

This step has a bit more variability that might be good to have coverage for, though technically it falls outside the scope of the ticket:

  • Whether liveness is enabled ([1] [2] [3] [4] [5] [6])
  • Whether an SP is associated with the session ([1])

@stevegsa stevegsa merged commit 5e4cdfb into main Apr 2, 2021
@stevegsa stevegsa deleted the stevegsa-test-upload-step branch April 2, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchellhenke mitchellhenke mitchellhenke approved these changes

+1 more reviewer

@aduth aduth aduth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status - ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevegsa @mitchellhenke @aduth