No longer autocorrecting the email field (Safari only) (LG-3842)#4845
Merged
No longer autocorrecting the email field (Safari only) (LG-3842)#4845
Conversation
zachmargolis
approved these changes
Mar 26, 2021
| <%= f.input :email, required: true, input_html: { aria: { invalid: false, describedby: 'email-description' } } %> | ||
| <%= f.input :email, | ||
| required: true, | ||
| input_html: { autocorrect: 'off', |
Contributor
There was a problem hiding this comment.
can we add a regression check for this in spec/views/devise/passwords/new.html.erb_spec.rb to make sure we don't accidentally remove it in the future?
aduth
approved these changes
Mar 26, 2021
solipet
force-pushed
the
dprice-lg-3842-disable-autocorrect
branch
from
3d339db to
598caf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a user navigated to secure.login.gov in Safari, and typed in
jane.doe@gsa.govthe field would autocorrect toJane.doe@gsa.gov. This PR preevents that on the sign in page, the create account page, and the forgot password page.