Remove redundant / unreachable backup code buttons helpers#4875
Merged
Conversation
**Why**: `continue_bttn_class` is only referenced on the depleted view, despite being a method defined on the BackupCodeCreatePresenter class. Since the create view itself hard-codes the same big, wide button as other backup code views, there is no variation of the classes between presenters and it can be removed. Similarly, the text "Continue" is the same between the create and depleted views, despite using separate locale string keys. Instead, consolidate to the "forms.buttons.continue" and remove the helper method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered as part of investigative work of #4869
Why:
continue_bttn_classis only referenced on the depleted view, despite being a method defined on the BackupCodeCreatePresenter class. Since the create view itself hard-codes the same big, wide button as other backup code views, there is no variation of the classes between presenters and it can be removed.Similarly, the text "Continue" is the same between the create and depleted views, despite using separate locale string keys. Instead, consolidate to the "forms.buttons.continue" and remove the helper method.
There's expected to be no visual or text changes as a result of these revisions.