LG-4312 Remove analytics_user override of default analytics user

[stevegsa]

No description provided.

[aduth]

I'm finding quite a few places where we currently pass in user_id as part of the hash. I only found one when the ticket was first created, in the hybrid image upload flow:

identity-idp/app/forms/idv/api_image_upload_form.rb

Line 108 in 24dcf62

user_id: user_uuid,

But now I see lots of others as well. Just a few examples:

identity-idp/app/controllers/concerns/unconfirmed_user_concern.rb

Line 26 in 24dcf62

user_id: @user.uuid,

identity-idp/app/controllers/users/sessions_controller.rb

Line 143 in 24dcf62

user_id: user.uuid,

identity-idp/app/forms/add_user_email_form.rb

Line 60 in 24dcf62

user_id: existing_user.uuid,

Some of these might not be necessary to override, but in the end it seems not to be quite as safe or straight-forward to remove the attribute as I'd imagined when the ticket was first written.

That we have multiple ways and formats to pass user for analytics is still confusing. An alternative could be to flip it so we remove the analytics_user implementation, and instead always pass a user_id. We only have two instances of that:

identity-idp/app/controllers/frontend_log_controller.rb

Lines 23 to 25 in 24dcf62

	def analytics_user
	effective_user || super
	end

identity-idp/app/controllers/idv/capture_doc_controller.rb

Lines 56 to 58 in 24dcf62

	def analytics_user
	user_id_from_token ? User.find(user_id_from_token) : super
	end

The frontend log would be easy enough to convert. CaptureDocController is tricky, since I think each step uses the controller, so having one place to control the analytics user is convenient 😕

Maybe we should leave it as it is?

[aduth]

Looks good to me 👍