LG-4359 Cannot redirect to nil! error during signup

[stevegsa]

Why: There is a race condition (0.04% frequency) where one request overwrites session and deletes the request_url from the sp while the other request consents to the terms but the session has no way back to the sp. In that situation redirect back to the accounts page or the root if the session is no longer valid.

[mitchellhenke]

Is this a double submit situation?

[stevegsa]

Is this a double submit situation?

No. It is another request sometimes from another SP and generally comes in through the root. Somehow it is maintaining the session/sign in but deleting the sp.

[zachmargolis]

LGTM, this fixes the error, but is the user experience that they want to be directed back to the SP? should we be trying to save a copy of the SP URL somewhere else, or trying to resolve the race condition somehow?

[mitchellhenke]

I think this could be fixed further up the chain (and potentially more precisely) by redirecting to account in https://github.com/18F/identity-idp/blob/main/app/controllers/users/authorization_confirmation_controller.rb if there is no SP present

[stevegsa]

I think this could be fixed further up the chain (and potentially more precisely) by redirecting to account in https://github.com/18F/identity-idp/blob/main/app/controllers/users/authorization_confirmation_controller.rb if there is no SP present

Hiya @solipet :-) On user_authorization_confirmation would it make sense to redirect to account on the show if there is no sp_session?