Refactor account action button as independent from BassCSS#4840
Merged
Conversation
aduth
force-pushed
the
aduth-btn-account-action
branch
from
defc91a to
c395768
Compare
mitchellhenke
approved these changes
Mar 26, 2021
**Why**: As part of LG-3865, will be eliminating BassCSS buttons as a dependency. Account action buttons currently inherit styles from BassCSS, and there is not a standalone design system alternative.
aduth
force-pushed
the
aduth-btn-account-action
branch
from
c395768 to
5befe12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #4836 (comment)
Why: As part of LG-3865, will be eliminating BassCSS buttons as a dependency. Account action buttons currently inherit styles from BassCSS, and there is not a standalone design system alternative.
It's expected that account action buttons should appear visually identical before and after these changes.