Allow SPs to have multiple certs (LG-2049)#4851
Conversation
plumb fingerprint in to saml_idp.service_provider directly
|
|
||
| class ServiceProvider < ApplicationRecord | ||
| self.ignored_columns = %w[deal_id agency aal] | ||
| self.ignored_columns = %w[deal_id agency aal fingerprint] |
There was a problem hiding this comment.
this was a very old column and adding it here makes sure we don't reference it at all
There was a problem hiding this comment.
this was a very old column and adding it here makes sure we don't reference it at all
Appears we may still be referencing it during local development make setup:
This is preventing make setup from succeeding:
ActiveModel::UnknownAttributeError: unknown attribute 'fingerprint' for ServiceProvider.
/Users/Documents/Code/identity-idp/app/services/service_provider_seeder.rb:20:in `block in run'
/Users/Documents/Code/identity-idp/app/services/service_provider_seeder.rb:13:in `each'
/Users/Documents/Code/identity-idp/app/services/service_provider_seeder.rb:13:in `run'
/Users/Documents/Code/identity-idp/db/seeds.rb:2:in `<main>'
We do want to remove that configuration value from the second file?
There was a problem hiding this comment.
Also, should fingerprint be removed from COLUMNS in NullServiceProvider? Currently it behaves differently between ServiceProvider and NullServiceProvider:
[3] pry(main)> ServiceProvider.new.fingerprint
NoMethodError: undefined method `fingerprint' for #<ServiceProvider:0x00007fad4c15e810>
from /Users/andrewmduthie/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activemodel-6.1.3.1/lib/active_model/attribute_methods.rb:469:in `method_missing'
[7] pry(main)> NullServiceProvider.new(issuer:nil).fingerprint
=> nil
There was a problem hiding this comment.
thanks for these catches... will make a PR to remedy
solipet
left a comment
There was a problem hiding this comment.
Looks great - just one question
orenyk
left a comment
There was a problem hiding this comment.
Looks good! A few questions below.
* Revert "Ensure non-nil fingerprint for SAML logout (#4890)" This reverts commit 00deec6. * Revert "Stop referencing ServiceProvider#fingerprint (#4884)" This reverts commit 7fe7be7. * Revert "Remove fingerprint from seeded local development service provider (#4877)" This reverts commit a8c9481. * Revert "Allow SPs to have multiple certs (LG-2049) (#4851)" This reverts commit 0efa17f. * Restore migration from multi-cert * Re-add certs column to NullServiceProvider
* Revert "Ensure non-nil fingerprint for SAML logout (#4890)" This reverts commit 00deec6. * Revert "Stop referencing ServiceProvider#fingerprint (#4884)" This reverts commit 7fe7be7. * Revert "Remove fingerprint from seeded local development service provider (#4877)" This reverts commit a8c9481. * Revert "Allow SPs to have multiple certs (LG-2049) (#4851)" This reverts commit 0efa17f. * Restore migration from multi-cert * Re-add certs column to NullServiceProvider
This PR should let us manage multiple certs per SP.
At a high level:
Next steps: