update saml_idp gem to handle default aal authn context#4885
Merged
Conversation
achapm
requested review from
aduth,
mitchellhenke,
orenyk,
solipet and
zachmargolis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a service provider passes the default aal value (urn:gov:gsa:ac:classes:sp:PasswordProtectedTransport:duo) in the authn contexts it will not be returned in the SamlIdp::Request.requested_aal_authn_context
Added tests to confirm that urn:gov:gsa:ac:classes:sp:PasswordProtectedTransport:duo is returned as expected.
More information on the saml_idp PR here:
18F/saml_idp#38
Quote from @aduth on the saml_idp PR:
Just to clarify, we'd not want to return the default value as a fallback from requested_aal_authn_context because the method is intended to return only what's been requested by an SP, and the defaulting behavior in the IDP isn't sufficient because it may try for an IAL context before returning the IAL default value?