Merged
Conversation
zachmargolis
approved these changes
Mar 26, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! Should inlining the code from the identity-idp-functions be a followup PR?
Comment on lines
-31
to
-37
| auth_request_timeout: AppConfig.env.aamva_auth_request_timeout, | ||
| auth_url: AppConfig.env.aamva_auth_url, | ||
| cert_enabled: AppConfig.env.aamva_cert_enabled, | ||
| private_key: AppConfig.env.aamva_private_key, | ||
| public_key: AppConfig.env.aamva_public_key, | ||
| verification_request_timeout: AppConfig.env.aamva_verification_request_timeout, | ||
| verification_url: AppConfig.env.aamva_verification_url, |
Contributor
There was a problem hiding this comment.
we still need to pass these configs in, inside the job classes now right?
Contributor
There was a problem hiding this comment.
nevermind, I didn't realize we had copied these there already
Contributor
Author
There was a problem hiding this comment.
yep, all good. we'll want to test in staging to make sure the credentials make it appropriately and everything though
mitchellhenke
force-pushed
the
mitchellhenke/remove-some-lambda
branch
from
3758f78 to
51de81b
Compare
mitchellhenke
force-pushed
the
mitchellhenke/remove-some-lambda
branch
from
51de81b to
48312ef
Compare
Contributor
Author
|
@zachmargolis Is it alright to force merge? |
Contributor
|
@mitchellhenke done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies some of the Ruby Worker work that's ongoing