Skip to content

Remove references to SimpleForm required markup#4855

Merged
aduth merged 1 commit intomainfrom
aduth-rm-required-simple-form
Mar 31, 2021
Merged

Remove references to SimpleForm required markup#4855
aduth merged 1 commit intomainfrom
aduth-rm-required-simple-form

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 31, 2021

Why:

  • We hide it anyways, both visually and from assistive technology
  • If it were to be visible, it would use non-standard red color instead of design system (facilitates LG-3877)

See: #4854 (comment)

**Why**:

- We hide it anyways, both visually and from assistive technology
- If it were to be visible, it would use non-standard red color instead of design system (facilitates LG-3877)

See: #4854 (comment)
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduth aduth merged commit 809cb18 into main Mar 31, 2021
@aduth aduth deleted the aduth-rm-required-simple-form branch March 31, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants