Fix button block link styling from USWDS migration

[aduth]

Related: #4836

Why: Prior to #4836, there were a few instances of links which used the block class to extend the width of the link to occupy the full width of its container. Since the USWDS button applies its own display: inline-block which takes precedence over the block utility class, this caused these links to shrink unintentionally.

Solution:

• In the "Reactivate Account" screen, replace block with usa-button--full-width as an equivalent effect
• In IDV session errors screen, refactor links to replicate the equivalent <BlockLink /> React component added for document capture step in LG-4308: Update messaging for "Return to SP" link in document capture #4751.

Discovered using full-project search patterns block[^'"]+usa-button, usa-button[^'"]+block, f\.button([^%]|\n)+block.

Screenshots:

Reactivate Account:

Before	After

IDV Session Errors:

Before	After

Note that the two links are usually mutually exclusive and not shown at the same time, depending if the user is verifying their identity from an SP or recovering from a password reset.

[zachmargolis]

LGTM, are any of the patterns you mentioned in the description good to add to our ERB lint?

block[^'"]+usa-button, usa-button[^'"]+block, f\.button([^%]|\n)+block.

[aduth]

LGTM, are any of the patterns you mentioned in the description good to add to our ERB lint?

block[^'"]+usa-button, usa-button[^'"]+block, f\.button([^%]|\n)+block.

Maybe, but I think we can / should include the block class as deprecated when we come to removing those BassCSS stylesheets. I also don't know that I'd consider these "deprecated" in the traditional sense, as opposed to a conflict between classes. At some point I'm thinking we could consider removing .erb_lint.yml altogether, or at least the deprecated rules.

I might circle back on this to see if there's a follow-up task we could create for these kinds of "known conflicts".

[aduth]

Heh, the build failure caught an interesting issue, which is that the ">" caret was previously a separate link directing to the wrong URL. This should have been account_reset_request_path.

[anniehirshman-gsa]

FWIW LGTM! 👍