Conversation
aduth
force-pushed
the
aduth-lg-3865-rm-btn
branch
from
a21c6b5 to
e9cf8aa
Compare
aduth
force-pushed
the
aduth-lg-3865-rm-btn
branch
2 times, most recently
from
aba606c to
eccd541
Compare
aduth
force-pushed
the
aduth-lg-3865-rm-btn
branch
from
814b921 to
eb0a75f
Compare
Contributor
Author
|
This should be ready now. |
zachmargolis
approved these changes
Mar 31, 2021
Contributor
There was a problem hiding this comment.
This is my new favorite property
Contributor
There was a problem hiding this comment.
these are great matcher cleanups!
Contributor
Author
There was a problem hiding this comment.
these are great matcher cleanups!
Motivated in part because the previous implementation would have exceeded Rubocop's acceptable line length 😄
**Why**: As a user, I expect that login.gov has a consistent visual style, and that my page load times are not prolonged by loading redundant CSS. As a developer, I expect that existing references to BassCSS module classes are replaced with equivalent USWDS or ad hoc alternatives, so that we can successfully migrate away from and eliminate our dependency on BassCSS.
**Why**: While it's the standard button size for most form buttons, notably the "unstyled" button doesn't unset big appearance, and in most all usage we'd not want unstyled buttons to appear large. Also good to be explicit even if standard, since "big" should arguably be a conscious decision for a form button.
aduth
force-pushed
the
aduth-lg-3865-rm-btn
branch
from
eb0a75f to
6cad617
Compare
This was referenced Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a user, I expect that login.gov has a consistent visual style, and that my page load times are not prolonged by loading redundant CSS. As a developer, I expect that existing references to BassCSS module classes are replaced with equivalent USWDS or ad hoc alternatives, so that we can successfully migrate away from and eliminate our dependency on BassCSS.
Screenshot:
This is just one example of a primary form submission being updated to an equivalent design system button: