Conversation
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Looks like two errors are missing the french translation (unless I'm missing it)? LInes 112 and 113 of the spreadsheet
@anniehirshman-gsa They were already correct (I copied the text from the translations and searched/found them in the existing file): |
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Perfect thanks for confirming!
| phone_voice_label: Phone number | ||
| piv_cac_fallback: | ||
| question: Don't have your piv/cac card available? | ||
| question: Don't have your PIV or CAC available? |
There was a problem hiding this comment.
Just to confirm, these strings aren't for IAL2. PIV/CAC verification was removed as of #4819. The updated texts read as an improvement to me all the same, so I think they'd be fine, but wanted to double-check.
| invalid_file_input_type: No se acepta este tipo de archivo, elija un archivo | ||
| JPG, PNG, BMP o TIFF. | ||
| invalid_file_input_type: Ese formato no es admitido, por favor elija un archivo | ||
| JPG, PNG, BMP, o TIFF. |
There was a problem hiding this comment.
Something possibly worth following-up on: We're not always consistent with our use of Oxford comma. There's very similar error messages where we omit it (e.g. "Must be a JPG, BMP, PNG or TIFF", translated as "Debe ser un JPG, BMP, PNG o TIFF").
Since this is correct per our own English text and translation, I don't think it's a blocker.
3 participants
Updated translations from the spreadsheet.