Master 314#185
Closed
yiraeChristineKim wants to merge 256 commits into
Closed
Conversation
* Implement AssignImage mutator Signed-off-by: davis-haba <davishaba@google.com> * fix tests Signed-off-by: davis-haba <davishaba@google.com> * fix controller gen setup Signed-off-by: davis-haba <davishaba@google.com> * fix helm manifest generation Signed-off-by: davis-haba <davishaba@google.com> * WIP assignimage byPod status Signed-off-by: davis-haba <davishaba@google.com> * mutator pod status working for assignimage Signed-off-by: davis-haba <davishaba@google.com> * e2e test assignimage mutator deleted Signed-off-by: davis-haba <davishaba@google.com> * old kubectl run Signed-off-by: davis-haba <davishaba@google.com> * address comments. domain must have '.' unless localhost Signed-off-by: davis-haba <davishaba@google.com> * appease linter Signed-off-by: davis-haba <davishaba@google.com> * fix gator tests Signed-off-by: davis-haba <davishaba@google.com> * add test domain ending in colon still converges Signed-off-by: davis-haba <davishaba@google.com> * docs for assignimage Signed-off-by: davis-haba <davishaba@google.com> * remove newline Signed-off-by: davis-haba <davishaba@google.com> * address comments Signed-off-by: davis-haba <davishaba@google.com> * appease linter Signed-off-by: davis-haba <davishaba@google.com> * cleanup dead code branch Signed-off-by: davis-haba <davishaba@google.com> * validateDomain to use splitDomain Signed-off-by: davis-haba <davishaba@google.com> * future-proof validateImageParts. Add custom error types. Signed-off-by: davis-haba <davishaba@google.com> * fix readiness tracker test Signed-off-by: davis-haba <davishaba@google.com> * make manifests Signed-off-by: davis-haba <davishaba@google.com> * validate that splitting a valid tag never returns a path Signed-off-by: davis-haba <davishaba@google.com> * degenerate cases for unit tests. do not expose regex on image component error. Signed-off-by: davis-haba <davishaba@google.com> * test missing image field. update error copy. Signed-off-by: davis-haba <davishaba@google.com> * tag error copy Signed-off-by: davis-haba <davishaba@google.com> * Update pkg/expansion/system_test.go Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com> * Update pkg/mutation/mutators/assignimage/assignimage_mutator.go Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com> * errors.As instead of type casting in unit tests Signed-off-by: davis-haba <davishaba@google.com> * fix error type checking Signed-off-by: davis-haba <davishaba@google.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
…y-agent#2530) * Upgrade to k8s v0.26.1 and controller-runtime fork Signed-off-by: Max Smythe <smythe@google.com> * Re-add stop channel to informer map entry Signed-off-by: Max Smythe <smythe@google.com> * Update linter version Signed-off-by: Max Smythe <smythe@google.com> * Fix lint errors Signed-off-by: Max Smythe <smythe@google.com> * Fix broken tests Signed-off-by: Max Smythe <smythe@google.com> * Fix function docstring Signed-off-by: Max Smythe <smythe@google.com> * Fix gofumpt violation Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Max Smythe <smythe@google.com>
…-agent#2536) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…cy-agent#2535) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…ent#2543) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2547) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2546) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add --operation=mutation-controller flag Signed-off-by: davis-haba <davishaba@google.com> * operations in sorted order Signed-off-by: davis-haba <davishaba@google.com> * update mutation-controller op docs to indicate audit may also need the flag Signed-off-by: davis-haba <davishaba@google.com> --------- Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…cy-agent#2545) Introduce gci to unify the order of package import Signed-off-by: Fish-pro <zechun.chen@daocloud.io> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
…ted (since v1.49.0) (open-policy-agent#2550) Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…ent#2564) removed unused kustomize step Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…nt#2581) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2566) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2565) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2567) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2568) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Max Smythe <smythe@google.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
…n-policy-agent#2997) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…olicy-agent#2996) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
…ent#3041) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
…#3060) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#3070) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olicy-agent#3069) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> Co-authored-by: JaydipGabani <JaydipGabani@users.noreply.github.com>
…agent#3076) Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
…cy-agent#3086) Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Co-authored-by: sozercan <sozercan@users.noreply.github.com>
…ck for 3.14 (open-policy-agent#3141) Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com> Signed-off-by: alex <8968914+acpana@users.noreply.github.com> Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: sozercan <sozercan@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Yi Rae Kim <yikim@redhat.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com> Co-authored-by: mprahl <mprahl@users.noreply.github.com> Signed-off-by: Yi Rae Kim <yikim@redhat.com>
ref: https://issues.redhat.com/browse/ACM-6233 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> Co-authored-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> Signed-off-by: Yi Rae Kim <yikim@redhat.com>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: