Skip to content

ci: pin golang image to unblock ci#2573

Merged
sozercan merged 1 commit into
open-policy-agent:masterfrom
sozercan:pin-golang
Feb 10, 2023
Merged

ci: pin golang image to unblock ci#2573
sozercan merged 1 commit into
open-policy-agent:masterfrom
sozercan:pin-golang

Conversation

@sozercan
Copy link
Copy Markdown
Member

@sozercan sozercan commented Feb 8, 2023

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
This pins the golang image (used for test tooling) to a digest that contains Go 1.19.5 but without the git update to unblock pr tests

see #2569 for more details (keeping this open so we can use that for a longer-term fix)

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@sozercan sozercan requested a review from maxsmythe February 8, 2023 00:21
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 53.41% // Head: 53.60% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (799f014) compared to base (5ab923e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2573      +/-   ##
==========================================
+ Coverage   53.41%   53.60%   +0.18%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
+ Hits         5680     5700      +20     
+ Misses       4516     4501      -15     
+ Partials      438      433       -5     
Flag Coverage Δ
unittests 53.60% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 59.56% <0.00%> (+3.82%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copy link
Copy Markdown
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 6c10e27 into open-policy-agent:master Feb 10, 2023
@sozercan sozercan deleted the pin-golang branch February 10, 2023 05:24
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants