Skip to content

ci: bump ci to golang 1.20#2597

Merged
sozercan merged 2 commits into
open-policy-agent:masterfrom
sozercan:golang-120
Mar 24, 2023
Merged

ci: bump ci to golang 1.20#2597
sozercan merged 2 commits into
open-policy-agent:masterfrom
sozercan:golang-120

Conversation

@sozercan
Copy link
Copy Markdown
Member

@sozercan sozercan commented Feb 23, 2023

What this PR does / why we need it:
updates CI to Go 1.20

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2569

Special notes for your reviewer:

@sozercan sozercan force-pushed the golang-120 branch 2 times, most recently from a241238 to 6bb551f Compare February 23, 2023 19:58
@sozercan sozercan marked this pull request as draft February 23, 2023 20:16
@sozercan sozercan changed the title chore: bump to golang 1.20 ci: bump ci to golang 1.20 Feb 23, 2023
}

// seed random generator
rand.Seed(time.Now().UnixNano())
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The math/rand package now automatically seeds the global random number generator (used by top-level functions like Float64 and Int) with a random value, and the top-level Seed function has been deprecated.

https://tip.golang.org/doc/go1.20

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan marked this pull request as ready for review February 23, 2023 22:36
@sozercan sozercan requested a review from maxsmythe February 23, 2023 22:50
@sozercan sozercan added this to the v3.12.0 milestone Mar 1, 2023
@sozercan
Copy link
Copy Markdown
Member Author

@maxsmythe @ritazh PTAL when you get a chance

Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2023

Codecov Report

❌ Patch coverage is 46.34146% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.11%. Comparing base (df9a9d9) to head (34a4cf6).
⚠️ Report is 713 commits behind head on master.

Files with missing lines Patch % Lines
pkg/gator/verify/printer_go.go 0.00% 14 Missing ⚠️
pkg/gator/reader/read_constraints.go 0.00% 6 Missing ⚠️
pkg/gator/verify/runner.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
- Coverage   53.17%   53.11%   -0.06%     
==========================================
  Files         120      120              
  Lines       10569    10569              
==========================================
- Hits         5620     5614       -6     
- Misses       4513     4518       +5     
- Partials      436      437       +1     
Flag Coverage Δ
unittests 53.11% <46.34%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sozercan sozercan merged commit 852d1f4 into open-policy-agent:master Mar 24, 2023
@sozercan sozercan deleted the golang-120 branch March 24, 2023 01:45
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 31, 2023
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Apr 5, 2023
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: error obtaining VCS status: exit status 128

4 participants