feat: Add Recommended Helm/K8s labels

[ghost]

What this PR does / why we need it:
This PR adds in Helm and Kubernetes recommended labels, bringing gatekeeper in line with best practice.
See links for labelling info:
https://helm.sh/docs/chart_best_practices/labels/
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

Which issue(s) this PR fixes
Fixes #2774

[sozercan]

@jbruce-nex you can revert all the changes to /charts. /manifest_staging/charts will be promoted to /charts when we cut a release. Thanks!

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (33efb28) 53.02% compared to head (1ab3618) 53.08%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2788      +/-   ##
==========================================
+ Coverage   53.02%   53.08%   +0.05%     
==========================================
  Files         135      135              
  Lines       11790    11790              
==========================================
+ Hits         6252     6259       +7     
+ Misses       5050     5045       -5     
+ Partials      488      486       -2     

Flag	Coverage Δ
unittests	53.08% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ghost]

@jbruce-nex you can revert all the changes to /charts. /manifest_staging/charts will be promoted to /charts when we cut a release. Thanks!

Hi @sozercan have updated to remove changes to the charts directory - cheers!

[sozercan]

@jbruce-nex looks like helm build and upgrade tests are failing

[ritazh]

From the error, unfortunately it looks like the change is not backward compatible.

upgrade.go:139: [debug] preparing upgrade for gatekeeper
Error: UPGRADE FAILED: template: gatekeeper/templates/upgrade-crds-hook.yaml:67:8: executing "gatekeeper/templates/upgrade-crds-hook.yaml" at <include "gatekeeper.mandatoryLabels" .>: error calling include: template: gatekeeper/templates/_helpers.tpl:47:9: executing "gatekeeper.mandatoryLabels" at <"gatekeeper.name">: can't give argument to non-function "gatekeeper.name"
helm.go:88: [debug] template: gatekeeper/templates/upgrade-crds-hook.yaml:67:8: executing "gatekeeper/templates/upgrade-crds-hook.yaml" at <include "gatekeeper.mandatoryLabels" .>: error calling include: template: gatekeeper/templates/_helpers.tpl:47:9: executing "gatekeeper.mandatoryLabels" at <"gatekeeper.name">: can't give argument to non-function "gatekeeper.name"

[ghost]

Apologies on the delay - I have updated the templates to hopefully resolve the issue that @ritazh has posted. There was an error on my part in the template helper files

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[sozercan]

Thanks for the PR and sorry about the delay! LGTM

[maxsmythe]

LGTM