ci: fix gator cli build#2657
Merged
Merged
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
acpana
approved these changes
Mar 30, 2023
Contributor
acpana
left a comment
acpana
left a comment
There was a problem hiding this comment.
just two non blocking questions
|
|
||
| # wait for all pids | ||
| for pid in ${pids[*]}; do | ||
| wait $pid |
Contributor
There was a problem hiding this comment.
two thoughts
- wondering if we want a specific timeout here, besides the overall timeout defined on line 19 in this file for all jobs;
- did we want to fail the job if one of the pid's returns non zero?
Member
Author
There was a problem hiding this comment.
- no specific timeout, just timeout for the pipeline itself
- yea that is the proposed behavior in the PR (
set -e). we are not doing that today so we didn't know release of gator failed
maxsmythe
approved these changes
Mar 31, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for spotting this!
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
- Coverage 53.36% 53.23% -0.13%
==========================================
Files 120 120
Lines 10594 10594
==========================================
- Hits 5653 5640 -13
- Misses 4508 4518 +10
- Partials 433 436 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sozercan
added a commit
to sozercan/gatekeeper
that referenced
this pull request
Mar 31, 2023
sozercan
added a commit
to sozercan/gatekeeper
that referenced
this pull request
Mar 31, 2023
sozercan
added a commit
to sozercan/gatekeeper
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
added a commit
that referenced
this pull request
Mar 31, 2023
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes gator cli builds during release and it should mark the job as failed if build fails
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #2656
Special notes for your reviewer:
Will need to be cherry picked to release-3.12 branch after merged