feat: Adding pubsub interface#2538
Conversation
|
Open questions:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
- Coverage 53.56% 52.87% -0.69%
==========================================
Files 128 132 +4
Lines 11411 11629 +218
==========================================
+ Hits 6112 6149 +37
- Misses 4822 5001 +179
- Partials 477 479 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Here is a PR I came across that defined method definition for batching in dapr. This is a complete proposal for batching in dapr pub sub |
|
@maxsmythe according to this PPT, it seems I was wrong and at least with dapr, the subscriber will have a choice of bulk subscribe or simple subscribe (i.e how the subscriber can get messages). |
|
It looks like Dapr's response to the possibility of some clients not supporting bulk publishing is to have their library turn a bulk publish into a loop over the non-supporting client's publish call. |
|
Yes! According to this comment, non-supporting client's publish call can be made either |
d200ae9 to
1440f84
Compare
|
We want to add this to the validation webhook too, right? Or did you plan to do this as a follow up? |
Initially we will enable this with audit and then, later on, can integrate to different parts such as validation webhook. |
|
@sozercan @maxsmythe @nilekhc @ritazh I am working on fixing CI errors, but this PR is ready for review |
maxsmythe
left a comment
There was a problem hiding this comment.
Sorry for the delay, added a few comments.
c92a982 to
6320696
Compare
…ror reporting on publish Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
maxsmythe
left a comment
There was a problem hiding this comment.
Code LGTM, last nit is on the Helm chart
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
|
@maxsmythe @sozercan made the change, PTAL. |
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Jaydip Gabani gabanijaydip@gmail.com
What this PR does / why we need it: This PR introduces a way to export violations and provides a way to consume all the violations without scanning the logs. For more details, please refer to this doc
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: