fix: index readiness trackers by GK (not GVK)#2635
Merged
Conversation
Signed-off-by: davis-haba <davishaba@google.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2635 +/- ##
==========================================
+ Coverage 53.19% 53.29% +0.10%
==========================================
Files 120 120
Lines 10594 10594
==========================================
+ Hits 5635 5646 +11
+ Misses 4522 4513 -9
+ Partials 437 435 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxsmythe
approved these changes
Mar 24, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing this!
davis-haba
added a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 31, 2023
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: davis-haba davishaba@google.com
What this PR does / why we need it:
Readiness tracking for the
AssignImagemutator was not working properly because the generic Mutation controller was hard coded to use versionv1to look up its tracker, howeverAssignImageis still inv1alpha1.Indexing trackers by version is unnecessary. The same tracker can be used to track resources of the same GK but different versions, with no impact to the current behavior.
Fixes #2634
Why not change
objKeystruct to storeGKinstead ofGVK? This presents some complications.objKeyis not strictly being used as a key, but also as a data store to denote a list of GVK's to watch. These use cases would have to be decoupled, which is a much more significant refactor than the change proposed here.