chore: modify the typecheck as prompted#2553
Merged
Merged
Conversation
acpana
reviewed
Feb 1, 2023
| v1beta1.ConstraintNameLabel: "a-constraint", | ||
| v1beta1.ConstraintKindLabel: "AConstraintKind", | ||
| v1beta1.PodLabel: podName, | ||
| v1beta1.ConstraintTemplateNameLabel: strings.ToLower(cstrKind), |
Author
There was a problem hiding this comment.
I've already found it, and I understand it's golang-lint problem, but in order to pass the check, I've made an irrelevant change
sozercan
approved these changes
Feb 7, 2023
Codecov ReportBase: 53.54% // Head: 53.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
==========================================
+ Coverage 53.54% 53.59% +0.04%
==========================================
Files 120 120
Lines 10634 10634
==========================================
+ Hits 5694 5699 +5
+ Misses 4506 4502 -4
+ Partials 434 433 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5aa9bef to
0fdad93
Compare
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
0fdad93 to
8f6d435
Compare
Author
|
@sozercan Thanks for update branch,Do you need me to rebase? |
Member
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fish-pro zechun.chen@daocloud.io
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: