Skip to content

docs: add landing page to website#2677

Merged
sozercan merged 6 commits into
open-policy-agent:masterfrom
salaxander:landing_page
Apr 28, 2023
Merged

docs: add landing page to website#2677
sozercan merged 6 commits into
open-policy-agent:masterfrom
salaxander:landing_page

Conversation

@salaxander
Copy link
Copy Markdown
Contributor

@salaxander salaxander commented Apr 4, 2023

What this PR does / why we need it:
This PR adds a landing page to the Gatekeeper website. See below images for how it looks. I also recommend trying it out by pulling my branch and running yarn start in the website directory.




Screenshot 2023-04-04 at 3 01 58 PM






Screenshot 2023-04-04 at 3 02 10 PM

@sozercan
Copy link
Copy Markdown
Member

sozercan commented Apr 4, 2023

@salaxander this is awesome! looks like PR needs DCO

Copy link
Copy Markdown
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spiffy new design!

One comment on Google Cloud's logo. Also looking for guidance on how GKE/Policy controller should be referenced.

Comment thread website/src/pages/index.js Outdated
website: 'https://learn.microsoft.com/en-us/azure/governance/policy/concepts/policy-for-kubernetes'
},
{
thumbnail: 'img/google_cloud.png',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure what to do for a logo/product reference here. Let me reach out.

Comment thread website/docusaurus.config.js
Comment thread website/src/pages/index.js Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 5, 2023

Codecov Report

Patch coverage: 40.40% and project coverage change: -0.33 ⚠️

Comparison is base (143e8cf) 53.27% compared to head (954b4f0) 52.94%.

❗ Current head 954b4f0 differs from pull request most recent head ae2e6b0. Consider uploading reports for the commit ae2e6b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
- Coverage   53.27%   52.94%   -0.33%     
==========================================
  Files         120      123       +3     
  Lines       10594    10926     +332     
==========================================
+ Hits         5644     5785     +141     
- Misses       4515     4688     +173     
- Partials      435      453      +18     
Flag Coverage Δ
unittests 52.94% <40.40%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/status/v1beta1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
pkg/controller/config/config_controller.go 63.82% <ø> (ø)
pkg/gator/reader/read_constraints.go 12.50% <0.00%> (ø)
pkg/gator/verify/printer_go.go 46.78% <0.00%> (ø)
pkg/mutation/match/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
pkg/webhook/common.go 65.21% <ø> (ø)
pkg/webhook/mutation.go 25.51% <0.00%> (ø)
pkg/webhook/policy.go 37.76% <4.34%> (-1.32%) ⬇️
...status/v1beta1/expansiontemplatepodstatus_types.go 8.69% <8.69%> (ø)
apis/status/v1beta1/util.go 76.31% <25.00%> (ø)
... and 19 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@salaxander
Copy link
Copy Markdown
Contributor Author

@maxsmythe updated the Google logo on the contributors section




Screenshot 2023-04-05 at 1 21 45 PM

Copy link
Copy Markdown
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM but please defer to Max for his approval! thanks for the demo today

@thomasmckay
Copy link
Copy Markdown
Contributor

I've reached out internally to find out what is necessary, if anything, to add the Red Hat to the list of contributors. I'll open a PR when I have the go-ahead.

@salaxander
Copy link
Copy Markdown
Contributor Author

@sozercan @ritazh - going to push some changes to address dark mode, after that do you feel there are any items blocking a merge for the initial version?

@sozercan
Copy link
Copy Markdown
Member

@salaxander sgtm if we are in the clear with all the logo usage

@salaxander
Copy link
Copy Markdown
Contributor Author

@salaxander sgtm if we are in the clear with all the logo usage

I believe we're good with the logos currently represented on the page. RedHat would be added after approvals are in order

@salaxander
Copy link
Copy Markdown
Contributor Author

@sozercan @ritazh @nilekhc - just did a rebase on this, should be good to merge. If you'd like you can clone my branch and run a yarn start in the /website directory too see it live.

Comment thread website/src/pages/index.js Outdated
);
}

const Services = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we make these boxes similar in size?

image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move that to a future PR?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Could you open an issue to track it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #2730 for tracking.

Comment thread website/src/pages/index.js Outdated
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
salaxander and others added 3 commits April 27, 2023 08:33
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
@salaxander
Copy link
Copy Markdown
Contributor Author

@sozercan @ritazh We good to merge this?

@sozercan sozercan merged commit cf2e7d5 into open-policy-agent:master Apr 28, 2023
@poonam-lamba
Copy link
Copy Markdown

@salaxander I am the PM for the Policy Controller. The description for Policy Controller is not correct. Suggest : can we do something like what Istio does, use the high level brand and on click point to the product documentation.
image

@salaxander
Copy link
Copy Markdown
Contributor Author

@poonam-lamba certainly! Thanks for the suggestion. I'll get an update out ASAP

@nilekhc
Copy link
Copy Markdown
Contributor

nilekhc commented Apr 28, 2023

@poonam-lamba certainly! Thanks for the suggestion. I'll get an update out ASAP

@salaxander I opened #2731 for tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants