docs: add landing page to website#2677
Conversation
|
@salaxander this is awesome! looks like PR needs DCO |
maxsmythe
left a comment
There was a problem hiding this comment.
Thanks for the spiffy new design!
One comment on Google Cloud's logo. Also looking for guidance on how GKE/Policy controller should be referenced.
| website: 'https://learn.microsoft.com/en-us/azure/governance/policy/concepts/policy-for-kubernetes' | ||
| }, | ||
| { | ||
| thumbnail: 'img/google_cloud.png', |
There was a problem hiding this comment.
TBH I'm not sure what to do for a logo/product reference here. Let me reach out.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
- Coverage 53.27% 52.94% -0.33%
==========================================
Files 120 123 +3
Lines 10594 10926 +332
==========================================
+ Hits 5644 5785 +141
- Misses 4515 4688 +173
- Partials 435 453 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@maxsmythe updated the Google logo on the contributors section |
acpana
left a comment
There was a problem hiding this comment.
this LGTM but please defer to Max for his approval! thanks for the demo today
|
I've reached out internally to find out what is necessary, if anything, to add the Red Hat to the list of contributors. I'll open a PR when I have the go-ahead. |
|
@salaxander sgtm if we are in the clear with all the logo usage |
I believe we're good with the logos currently represented on the page. RedHat would be added after approvals are in order |
| ); | ||
| } | ||
|
|
||
| const Services = [ |
There was a problem hiding this comment.
Can we move that to a future PR?
There was a problem hiding this comment.
Sure. Could you open an issue to track it?
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
e5df48c to
c20b754
Compare
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
ce7ebbc to
fa63381
Compare
|
@salaxander I am the PM for the Policy Controller. The description for Policy Controller is not correct. Suggest : can we do something like what Istio does, use the high level brand and on click point to the product documentation. |
|
@poonam-lamba certainly! Thanks for the suggestion. I'll get an update out ASAP |
@salaxander I opened #2731 for tracking |



What this PR does / why we need it:


This PR adds a landing page to the Gatekeeper website. See below images for how it looks. I also recommend trying it out by pulling my branch and running
yarn startin the website directory.