fix: use log level 1 for debug#3039
Merged
Merged
Conversation
todo Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3039 +/- ##
==========================================
- Coverage 52.49% 52.46% -0.03%
==========================================
Files 134 134
Lines 11937 11948 +11
==========================================
+ Hits 6266 6269 +3
- Misses 5179 5188 +9
+ Partials 492 491 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mattes83
pushed a commit
to Mattes83/gatekeeper
that referenced
this pull request
Oct 25, 2023
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verbosity log levels (V level) are additive so starting at 2 is actually a higher level than
Debug. So in effect, today, if users uselog-level=DEBUGany log line that usesloggging.Debugas its V level will not see the line since we don't have a control for higher verbosity (>1) yet.Not sure why it was 2 to begin with but I think it may have been missed on the original PR that introduced it #482.