feat: introduce gci to unify the order of package import#2545
Merged
Conversation
Fish-pro
changed the title
gci to unify the order of package importgci to unify the order of package import
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
==========================================
+ Coverage 53.41% 53.46% +0.04%
==========================================
Files 120 120
Lines 10634 10634
==========================================
+ Hits 5680 5685 +5
+ Misses 4516 4512 -4
+ Partials 438 437 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
…cy-agent#2545) Introduce gci to unify the order of package import Signed-off-by: Fish-pro <zechun.chen@daocloud.io> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fish-pro zechun.chen@daocloud.io
What this PR does / why we need it:
The order of package import for some files in the code is not uniform, and this pr introduces
gcito regulate package import orderWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: