fix: generate mock name for expanded resources#2529
Merged
ritazh merged 6 commits intoMar 14, 2023
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
+ Coverage 53.68% 53.78% +0.09%
==========================================
Files 120 120
Lines 10634 10643 +9
==========================================
+ Hits 5709 5724 +15
+ Misses 4496 4491 -5
+ Partials 429 428 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxsmythe
reviewed
Jan 21, 2023
acpana
reviewed
Jan 23, 2023
Contributor
|
Though it looks like unit tests are breaking |
acpana
approved these changes
Mar 3, 2023
Contributor
acpana
left a comment
acpana
left a comment
There was a problem hiding this comment.
pending fix for TestExpand
Contributor
|
DCO check is failing? |
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
davis-haba
force-pushed
the
expansion-mock-names
branch
from
7e18e49 to
f4bdf03
Compare
ritazh
approved these changes
Mar 14, 2023
Member
ritazh
left a comment
ritazh
left a comment
There was a problem hiding this comment.
LGTM
I updated the PR description to match the updated implementation.
davis-haba
added a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: davis-haba davishaba@google.com
What this PR does / why we need it:
Generates a mock name for expanded resources. The mock name is a function of the generator's name, and the resultant kind.
A deployment named
nginx-deploymentwhich expands into a Pod would create a resultant Pod with a namenginx-deployment-pod.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Partly fixes #2485
Fix to update match schema will be added in separate PR.