feat: recursive expansion#2679
Merged
davis-haba merged 13 commits intoMay 10, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
==========================================
+ Coverage 52.79% 53.07% +0.28%
==========================================
Files 123 124 +1
Lines 10941 11182 +241
==========================================
+ Hits 5776 5935 +159
- Misses 4710 4772 +62
- Partials 455 475 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
maxsmythe
reviewed
Apr 5, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
Nice job!
Biggest missing piece is the need to figure out conflicting templates.
acpana
reviewed
Apr 6, 2023
Contributor
acpana
left a comment
acpana
left a comment
There was a problem hiding this comment.
this is looking great 🥇 ; main question about the graph impl
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
davis-haba
force-pushed
the
expansion-recursive
branch
from
2357e4a to
3e80ff6
Compare
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
maxsmythe
reviewed
Apr 21, 2023
Contributor
maxsmythe
left a comment
maxsmythe
left a comment
There was a problem hiding this comment.
Code LGTM, haven't looked at tests yet
Contributor
|
LGTM with nits, I mean |
maxsmythe
reviewed
Apr 21, 2023
Signed-off-by: davis-haba <davishaba@google.com>
acpana
approved these changes
Apr 25, 2023
Contributor
acpana
left a comment
acpana
left a comment
There was a problem hiding this comment.
thanks for addressing comments made earlier 🥇 ; I don't have anything else blocking on my end
Signed-off-by: davis-haba <davishaba@google.com>
Contributor
Author
sozercan
reviewed
May 8, 2023
anlandu
pushed a commit
to anlandu/gatekeeper
that referenced
this pull request
May 19, 2023
Implements recursive expansion Signed-off-by: Anlan Du <adu47249@gmail.com>
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements recursive expansion.
Example use case: one could configure Cronjobs to expand into a Jobs, which then expands into Pods.
If a cycle is detected which would result in infinite expansion, every template that belongs to that cycle is disabled.
This is to prevent a "first past the post" race condition where different pods may have different templates enabled depending on the order their controllers reconciled the templates.
By disabling all templates belonging to a cycle, we can guarantee that every controller is enforcing the same templates in the steady state (after controllers have finished reconciling all updates).
Fixes: #2511