Skip to content

chore: the linter structcheck varcheck and deadcode are deprecated (since v1.49.0)#2550

Merged
sozercan merged 2 commits into
open-policy-agent:masterfrom
Fish-pro:chore/del
Jan 31, 2023
Merged

chore: the linter structcheck varcheck and deadcode are deprecated (since v1.49.0)#2550
sozercan merged 2 commits into
open-policy-agent:masterfrom
Fish-pro:chore/del

Conversation

@Fish-pro
Copy link
Copy Markdown

… abandoned the linter. Replaced by unused.

Signed-off-by: Fish-pro zechun.chen@daocloud.io

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

… abandoned the linter. Replaced by unused.

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.53%. Comparing base (4a27fbf) to head (84d74ad).
Report is 680 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
- Coverage   53.56%   53.53%   -0.03%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
- Hits         5696     5693       -3     
- Misses       4505     4507       +2     
- Partials      433      434       +1     
Flag Coverage Δ
unittests 53.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit 431db17 into open-policy-agent:master Jan 31, 2023
maxsmythe pushed a commit to maxsmythe/gatekeeper that referenced this pull request Feb 7, 2023
…ted (since v1.49.0) (open-policy-agent#2550)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
…ted (since v1.49.0) (open-policy-agent#2550)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants