refactor: move util.Wildcard into its own package#2853
Merged
Conversation
Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
ddb3c76 to
60f73b8
Compare
maxsmythe
approved these changes
Jul 1, 2023
Contributor
maxsmythe
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
- Coverage 53.55% 53.48% -0.07%
==========================================
Files 133 133
Lines 11536 11536
==========================================
- Hits 6178 6170 -8
- Misses 4882 4888 +6
- Partials 476 478 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sozercan
approved these changes
Jul 5, 2023
This was referenced Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We ran into an issue when updating our product to controller-runtime 0.15. We tried gatekeeper v3.13.0-beta.1 and ended up with
This is because the signature for MapFuncs has changed to include a
context.Contextnow.To solve this issue, this PR moves the
util.Wildcardtype into its own package (analogous topkg/version). This removes the dependency fromapis/config/v1alpha1topkg/util, thereby removing the need to compile-in a full-blown controller-runtime library for anyone who wants to use Gatekeeper'sconfig/v1alpha1API.