Skip to content

ci: Upgrade checkout action to v3#2658

Merged
sozercan merged 1 commit into
open-policy-agent:masterfrom
bmuschko:bm/license-lint-checkout-v3
Mar 30, 2023
Merged

ci: Upgrade checkout action to v3#2658
sozercan merged 1 commit into
open-policy-agent:masterfrom
bmuschko:bm/license-lint-checkout-v3

Conversation

@bmuschko
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Upgrades checkout action to v3

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #2605

Special notes for your reviewer:

None

Signed-off-by: Benjamin Muschko <benjamin.muschko@gmail.com>
@bmuschko
Copy link
Copy Markdown
Contributor Author

Looks like the check "Semantic PR" is failing. What exactly is expected here?

@ritazh
Copy link
Copy Markdown
Member

ritazh commented Mar 30, 2023

Looks like the check "Semantic PR" is failing. What exactly is expected here?

The title needs to be prefixed with values from https://github.com/open-policy-agent/gatekeeper/blob/master/.github/semantic.yml e.g. chore or ci

@ritazh ritazh changed the title Upgrade checkout action to v3 ci: Upgrade checkout action to v3 Mar 30, 2023
Copy link
Copy Markdown
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (e33c551) 53.36% compared to head (24c4f87) 53.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2658      +/-   ##
==========================================
- Coverage   53.36%   53.30%   -0.06%     
==========================================
  Files         120      120              
  Lines       10594    10594              
==========================================
- Hits         5653     5647       -6     
- Misses       4508     4513       +5     
- Partials      433      434       +1     
Flag Coverage Δ
unittests 53.30% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sozercan
Copy link
Copy Markdown
Member

Thank you!

@sozercan sozercan merged commit c04b2ed into open-policy-agent:master Mar 30, 2023
@bmuschko
Copy link
Copy Markdown
Contributor Author

@ritazh Thanks, I'll keep that in mind for my next contribution. I think it would make sense to mention the commit message expectations explicitly in the contribution guide here.

@bmuschko bmuschko deleted the bm/license-lint-checkout-v3 branch March 30, 2023 17:31
@ritazh
Copy link
Copy Markdown
Member

ritazh commented Mar 30, 2023

@ritazh Thanks, I'll keep that in mind for my next contribution. I think it would make sense to mention the commit message expectations explicitly in the contribution guide here.

Feel free to update the docs or ask questions if we can make contribution easier.
Re: Semantic PR, it's documented here https://open-policy-agent.github.io/gatekeeper/website/docs/help/#contributing-process

Create a GitHub Pull Request for your change, following the instructions in the pull request template and use semantic PR title

davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 31, 2023
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Apr 5, 2023
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update license lint to use checkout v3

4 participants