chore: Upgrade to k8s v0.26.1 and controller-runtime fork#2530
Merged
maxsmythe merged 8 commits intoJan 25, 2023
Merged
Conversation
maxsmythe
changed the title
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
from
2813bf3 to
17b7e9b
Compare
Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
2 times, most recently
from
af03bb5 to
36b1fe8
Compare
Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
upgrade-controller-runtime-and-k8s
branch
from
36b1fe8 to
2ecccf2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
- Coverage 53.51% 53.42% -0.09%
==========================================
Files 120 120
Lines 10635 10643 +8
==========================================
- Hits 5691 5686 -5
- Misses 4511 4521 +10
- Partials 433 436 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxsmythe
changed the title
sozercan
reviewed
Jan 24, 2023
| go 1.18 | ||
|
|
||
| // Prevent otel dependencies from getting out of sync. | ||
| replace ( |
Member
There was a problem hiding this comment.
we'll need to make this change in frameworks too, adding as a reminder.
sozercan
approved these changes
Jan 24, 2023
Member
sozercan
left a comment
sozercan
left a comment
There was a problem hiding this comment.
Thanks for updating this! LGTM
ritazh
reviewed
Jan 24, 2023
| return tracker, nil | ||
| } | ||
|
|
||
| // SetupTracker sets up a readiness tracker and registers it to run under control of the |
Member
There was a problem hiding this comment.
Is the comment for SetupTrackerNoReadyz?
ritazh
reviewed
Jan 24, 2023
| # sigs.k8s.io/controller-runtime | ||
|
|
||
| Forked from sigs.k8s.io/controller-runtime@a8c19c49e49cfba2aa486ff322cbe5222d6da533 (v0.8.2). | ||
| Forked from sigs.k8s.io/controller-runtime@6d2d247cb6f3a26e6b5597c2aa4a943a90c988bb (v0.14.1). |
Member
There was a problem hiding this comment.
Is it possible to push these changes to CR upstream now that it's alot more up to date?
Contributor
Author
There was a problem hiding this comment.
We can certainly try, but I wouldn't block this PR on it.
Member
|
Thanks for the PR @maxsmythe! The third_party stuff is becoming really hard to update/review with each update. |
ritazh
approved these changes
Jan 24, 2023
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Contributor
Author
|
Yeah, found this issue, which makes me hopeful that CR will eventually have something so we can remove the fork: |
Contributor
Author
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
…y-agent#2530) * Upgrade to k8s v0.26.1 and controller-runtime fork Signed-off-by: Max Smythe <smythe@google.com> * Re-add stop channel to informer map entry Signed-off-by: Max Smythe <smythe@google.com> * Update linter version Signed-off-by: Max Smythe <smythe@google.com> * Fix lint errors Signed-off-by: Max Smythe <smythe@google.com> * Fix broken tests Signed-off-by: Max Smythe <smythe@google.com> * Fix function docstring Signed-off-by: Max Smythe <smythe@google.com> * Fix gofumpt violation Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Max Smythe <smythe@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max Smythe smythe@google.com
What this PR does / why we need it:
Upgrade K8s and controller-runtime libraries... let's see if tests pass (WIP)
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: