teste #1
Merged
teste #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What is this PR for? sparkr.zip is not distrubuted to executor, so any sparkR job that requrie R daemon in executor will fail. This PR would add sparkr.zip into `spark.yarn.dist.archives`. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1425 ### How should this be tested? Run the following code ``` %spark.r df <- createDataFrame(sqlContext, mtcars) showDF(df) ``` ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #1423 from zjffdu/ZEPPELIN-1425 and squashes the following commits: 145a8dc [Jeff Zhang] ZEPPELIN-1425. sparkr.zip is not distributed to executors
### What is this PR for? This PR fixes [ZEPPELIN-1417](https://issues.apache.org/jira/browse/ZEPPELIN-1417 ). ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1417 ### How should this be tested? 1. click `edit` whatever interpreter you want on interpreter setting page. 2. check the `Connect to existing process` and set `host` or `port` value. 3. uncheck the `Connect to existing process` and save 4. run paragraph with just you saved interpreter. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1411 from astroshim/ZEPPELIN-1417 and squashes the following commits: 0ff0f4e [astroshim] remove isConnectExistingProcess() c84046c [astroshim] change to create local interpreter when option is false.
…notebook permissions ### What is this PR for? This is about storing the owner information on creating a note so when the same user tries to edit the permissions of the note he could do it successfully. ### What type of PR is it? Improvement ### Todos NA ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1142 ### How should this be tested? Check the below cases via the web application or REST API calls and the owner information should be persisted properly. * Create note * Clone note * Import note ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kavin <[email protected]> Closes #1393 from kavinkumarks/zeppelin-1142-simultaneous-note-permission-error and squashes the following commits: 5a45c9e [Kavin] Ensure that the authentication instance is created only when the input prinicipal is not null. 7642f63 [Kavin] Removed the duplicate instance of notebook variable and reused the existing one. e1b8b08 [Kavin] Store owner information on creating a note and added integration test cases for the relevant scenarios.
### What is this PR for? This is to make storage layer sync function aware of the user ### What type of PR is it? Improvement ### Todos * [x] - change function and test ### What is the Jira issue? [ZEPPELIN-1426](https://issues.apache.org/jira/browse/ZEPPELIN-1426) ### How should this be tested? corresponding storage layer tests should pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1424 from khalidhuseynov/storage/sync-with-subject and squashes the following commits: 7cc8455 [Khalid Huseynov] propagate subject to sync()
…d or write permission ### What is this PR for? If logged in user does not have Read and Write permission for a notebook, user should not see the notebook in the zeppelin home page. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1144 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Minwoo Kang <[email protected]> Closes #1330 from mwkang/ZEPPELIN-1144 and squashes the following commits: 82beb18 [Minwoo Kang] User see read, write, owner permission notebook.
### What is this PR for? After #1330 merged, the latest master build failed with below compilation errors. ``` [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol symbol: method id() location: variable note1 of type org.apache.zeppelin.notebook.Note [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol symbol: method id() location: variable note2 of type org.apache.zeppelin.notebook.Note ``` ### What type of PR is it? Hot Fix ### What is the Jira issue? ### How should this be tested? - Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine` - Apply this patch and build with `mvn clean package -DskipTests` -> build success You can also check #1330 works properly. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1432 from AhyoungRyu/hotfix/ZEPPELIN-1144 and squashes the following commits: 6a3dbd3 [AhyoungRyu] Fix build error in Notebook.java
### What is this PR for? There is a dead link in [docs/README.md](https://github.com/apache/zeppelin/blob/master/docs/README.md). It should be `https://zeppelin.apache.org/docs/latest/` not `https://zeppelin.apache.org/docs/latest` ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1421](https://issues.apache.org/jira/browse/ZEPPELIN-1421) ### How should this be tested? - Before [https://zeppelin.apache.org/docs/latest](https://zeppelin.apache.org/docs/latest) - After [https://zeppelin.apache.org/docs/latest/](https://zeppelin.apache.org/docs/latest/) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1420 from AhyoungRyu/ZEPPELIN-1421 and squashes the following commits: 57336f8 [AhyoungRyu] Remove BASE_PATH in some docs pages 311e2ef [AhyoungRyu] Fix dead link in docs/README.md
…lling remove inside foreach loop ### What is this PR for? We should use Iterator to iterate the list when we want to remove items in the middle of iteration, Otherwise will get the ConcurrentModificationException ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1420 ### How should this be tested? No test added ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #1419 from zjffdu/ZEPPELIN-1420 and squashes the following commits: ddd0710 [Jeff Zhang] ZEPPELIN-1420. java.util.ConcurrentModificationException caused by calling remove inside foreach loop
### What is this PR for? Several changes on doc of spark interpreter. * %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name. * Add SparkSession for 2.0 * Also add comments inline with other changes to explain the reason. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <[email protected]> Author: Jeff Zhang <[email protected]> Author: Jeff Zhang <[email protected]> Closes #1398 from zjffdu/spark_doc_fix and squashes the following commits: ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung 5fa523f [AhyoungRyu] Fix typos 3c0f678 [AhyoungRyu] Add 'R' and refine a sentence 2336900 [AhyoungRyu] Improve spark.md 40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
### What is this PR for?
here're several ways to load interpreter-setting.json, but for now we will load it multiple times. It is supposed to load only once. We should load it by the following orders
* 1. Register it from path {ZEPPELIN_HOME}/interpreter/{interpreter_name}/ interpreter-setting.json
* 2. Register it from interpreter-setting.json in classpath {ZEPPELIN_HOME}/interpreter/{interpreter_name}
* 3. Register it by Interpreter.register
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1368
### How should this be tested?
Check the log that each interpreter is registered once. And also modify file interpreter/spark/interpreter-setting.json to make pyspark as the default interpreter and it works. Before this PR, it doesn't work, because it would be override by interpreter-setting.json in `interpreter/spark/zeppelin-spark_2.10-0.7.0-SNAPSHOT.jar`
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <[email protected]>
Closes #1435 from zjffdu/ZEPPELIN-1368 and squashes the following commits:
8266d12 [Jeff Zhang] ZEPPELIN-1368. interpreter-setting.json may be loaded mutliple times
### What is this PR for? This started happening after ZEPPELIN-1144, #1330. This test (testGroupPermission) is to validate the group related permission on a notebook. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Fix CI ### What is the Jira issue? * [ZEPPELIN-1456](https://issues.apache.org/jira/browse/ZEPPELIN-1456) ### How should this be tested? CI xxx.10 (selenium) should be green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes #1444 from prabhjyotsingh/ZEPPELIN-1456 and squashes the following commits: 3c81587 [Prabhjyot Singh] ZEPPELIN-1456: fix
… 'parseDataType' ### What is this PR for? The root cause is that SQLContext's signature changes in spark 2.0. Spark 1.6 ``` def __init__(self, sparkContext, sqlContext=None): ``` Spark 2.0 ``` def __init__(self, sparkContext, sparkSession=None, jsqlContext=None): ``` So we need to create SQLContext using named parameters, otherwise it would take intp.getSQLContext() as sparkSession which cause the issue. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1411 ### How should this be tested? Tested using the example code in ZEPPELIN-1411. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #1404 from zjffdu/ZEPPELIN-1411 and squashes the following commits: 40b080a [Jeff Zhang] retry 4922de1 [Jeff Zhang] log more logging for travis CI diangnose 4fe033d [Jeff Zhang] add unit test 296c63f [Jeff Zhang] ZEPPELIN-1411. UDF with pyspark not working - object has no attribute 'parseDataType'
### What is this PR for? PR is for logging configuration details of Zeppelin server. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1182 ### How should this be tested? Please check the log if information on Server host, server path, context path, zeppelin version, class path is available in that file. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Note: For configuration details such as zeppelin version, server host, port & context path , these are available as part of zeppelin configuration. Logging information ``` INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:107) - Server Host: 0.0.0.0 INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:108) - Server Port: 8080 INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:109) - Context Path: / INFO [2016-09-02 14:35:25,224] ({main} ZeppelinConfiguration.java[create]:110) - Zeppelin Version: 0.7.0-SNAPSHOT ``` For Zeppelin class path and restart information, I am logging it from Shell script to log file as in below paragraph, So the format of logging is different . I know this is not per standards, Please let me know if you have any suggestions ``` Zeppelin is restarted ZEPPELIN_CLASSPATH: /home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/*::/home/rajarajang/Workspace/stsWorksapce/zeppelin/conf:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/classes ``` Author: rajarajan-g <[email protected]> Closes #1399 from rajarajan-g/ZEPPELIN-1182 and squashes the following commits: f4f7f44 [rajarajan-g] updated as per review comments da69b16 [rajarajan-g] Added log statements for configuration
### What is this PR for? Support table markdown syntax issued by [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. ### Todos * [ ] - Check the license issue of the [pegdown](https://github.com/sirthias/pegdown) library introduced by this PR ### What is the Jira issue? [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### How should this be tested? Write markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR. ### Screenshots (if appropriate) <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png"> ### Questions: * Does the licenses files need update? * Does coding style is appropriate? ### Additional Comments We might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark](zhenchuan/txtmark@1784868). But I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j. Author: 1ambda <[email protected]> Closes #1384 from 1ambda/fix-zeppelin-1387 and squashes the following commits: 16cda72 [1ambda] fix: Merge with 3c8158 to resolve CI failure e6d41c8 [1ambda] fix: Resolve merge conflict with 8f344db e08929a [1ambda] fix: Handle more specific exception in catch block 8b1e017 [1ambda] chore: Move github-markdown-css license to bin_licenses 4d1cb3c [1ambda] fix: Typo in docs/interpreter/markdown.md 85a5e3a [1ambda] fix: Use bower to install github-markdown-css 297733f [1ambda] fix: Modify github-markdown-css license 947a92a [1ambda] chore: Add license to newly created java files d228423 [1ambda] docs: Update markdown docs config, examples 2b6516c [1ambda] feat: Support markdown.parser.type attr in md d2d4455 [1ambda] style: Reformat using intellij-java-google-style bf9100d [1ambda] chore: Restore markdown4j dependency 55a2f10 [1ambda] fix: Add MarkdownParser interface to support mulitple parsers c33c715 [1ambda] fix: Remove the ANCHORLINKS option 9cf31d0 [1ambda] fix: Use markdown-body class (default) f741949 [1ambda] fix: Add styles for markdown 603d3db [1ambda] fix: Add missing transitive deps for pegdown 7aecdcb [1ambda] chore: Add pegdown to the binary license list fa14b3e [1ambda] style: Apply google java code style guide 029f550 [1ambda] [ZEPPELIN-1387] Support table in markdown interpreter
…tart" and "remove" btn in edit mode ### What is this PR for? "Currently there are no properties and dependencies set for this interpreter" message is shown when there are no properties & dependencies in interpreter setting page. But this message can be seen even in the edit mode. It's quite wired. This message needs to be shown only in non-editable mode. The `edit`, `restart` and `remove` button are same. - `edit` button doesn't do any work after changing to edit mode - `restart` button: it doesn't make sense that someone is editing and restarting interpreter at the same time - `remove` button: Maybe someone wants to remove the interpreter while he is editing the interpreter. But it would be better this button is shown only in non-editable mode for the consistency with the other buttons. For the above reasons, I changed those buttons to be shown in non-editable mode only. `Save` & `Cancel` buttons are enough to the edit page I think. Please see the attached gif image. ### What type of PR is it? Bug Fix ### What is the Jira issue? ### How should this be tested? 1. After applying this patch and build only `zeppelin-web` with `./grunt build` under `zeppelin-web`. 2. You can quickly check this change in dev mode with `./grunt serve`. 3. Go to `Interpreter` menu and click "edit" button on Angular interpreter to see "Currently there are no properties and dependencies set for this interpreter" message. Can also check the existence of `edit`, `restart` and `remove` buttons. ### Screenshots (if appropriate) - Before  - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Author: AhyoungRyu <[email protected]> Closes #1434 from AhyoungRyu/fix/editMode and squashes the following commits: 4433f86 [AhyoungRyu] Make same width 'properties'&'dependencies' table 2e50f5d [AhyoungRyu] Revert 'form' 0c6c937 [AhyoungRyu] Fix minor issues in interpreter setting edit mode
### What is this PR for? If for some reason (for example permission issue in file system) while saving interpreter setting, UI shows wrong value till the next restart. IMO interpreter.json should be the source of truth, that should always be reflected on UI ### What type of PR is it? [Bug Fix] ### Todos * [x] - read from file-system after saving ### What is the Jira issue? * [ZEPPELIN-1454](https://issues.apache.org/jira/browse/ZEPPELIN-1454) ### How should this be tested? Change file system permission of "interpreter.json", and make it readonly, then on interpreter setting page try and change any property and refresh the page, refer screenshot ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes #1437 from prabhjyotsingh/ZEPPELIN-1454 and squashes the following commits: f94125c [Prabhjyot Singh] ZEPPELIN-1454: read from file-system after saving
### What is this PR for? While creating connection `DriverManager.getConnection(url, properties);` for JDBC interpreter, phoenix driver is modifying the properties that is passed as parameter, which in modifies propertiesMap. This all is resulting in, not able to execute any other paragraph with phoenix interpreter. This only happens if JDBC URI is "jdbc:phoenix:thin:url" ### What type of PR is it? [Bug Fix] ### Todos * [x] - Pass a copy of `properties` to `DriverManager.getConnection(url, properties)` ### What is the Jira issue? * [ZEPPELIN-1459](https://issues.apache.org/jira/browse/ZEPPELIN-1459) ### How should this be tested? Use the example setting below https://issues.apache.org/jira/browse/ZEPPELIN-1459?focusedCommentId=15505750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505750 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes #1442 from prabhjyotsingh/ZEPPELIN-1459 and squashes the following commits: 906fe34 [Prabhjyot Singh] ZEPPELIN-1459: Zeppelin JDBC URL properties mangled
### What is this PR for? This is complete work of #1148. Comments and tasks on #1148 has been handled in this PR. - Add syntax language information in `interpreter-setting.json` - When user type `%replName` in paragraph, back-end check if the interpreter name with `replName` exists, and return language information to front-end if it does - If user doesn't specify `%replName`, default interpreter's language will be used - Using alias name for paragraph syntax highlight ### What type of PR is it? [Bug Fix | Improvement] ### What is the Jira issue? [ZEPPELIN-1026](https://issues.apache.org/jira/browse/ZEPPELIN-1026) ### How should this be tested? 1. Create new note and make markdown interpreter to be default. 2. See if markdown syntax is applied. ### Screenshots (if appropriate) #### Case 1. When the default interpreter set to python interpreter. **Before** Has `scala` as syntax highlight language when %python is not set. <img width="665" alt="screen shot 2016-07-07 at 10 46 20 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655312/af67a302-4494-11e6-949e-793ad0515d7a.png"> **After** Has `python` as syntax highlight language even when %python is not set. <img width="666" alt="screen shot 2016-07-07 at 10 44 39 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655248/769d8ba4-4494-11e6-9b3c-dc5e026e9c53.png"> #### Case 2. When use alias name as repl name. **Before** <img width="742" alt="screen shot 2016-09-08 at 4 22 39 pm" src="https://cloud.githubusercontent.com/assets/8503346/18353471/620c5ede-75e2-11e6-9d01-0726bc900dc0.png"> **After** <img width="741" alt="screen shot 2016-09-08 at 4 34 57 pm" src="https://cloud.githubusercontent.com/assets/8503346/18353487/6cdaa406-75e2-11e6-831a-08e0fa3a85d8.png"> ### Further possible improvements There are still several cases that Zeppelin doesn't handle syntax highlight well. These can be handled with another jira ticket/PR. 1. When default bound interpreter changes, syntax highlight is not changed accordingly 2. When copy/paste code, syntax highlight won't be applied properly since Zeppelin only checks changes when cursor is in first line. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes(for creating new interpreter) Author: Mina Lee <[email protected]> Closes #1415 from minahlee/ZEPPELIN-1026 and squashes the following commits: c66fb0e [Mina Lee] Move getEditorSetting to InterpreterFactory class 2d56222 [Mina Lee] Add description about default syntax highlight in doc 08ccad9 [Mina Lee] Fix test 0874522 [Mina Lee] Change condition for triggering 'getAndSetEditorSetting' to reduce front-end <-> back-end communication 9e4f2e9 [Mina Lee] Change the way to read interpreter language from interpreter-setting.json after #1145 75543b3 [Mina Lee] Add test 565d9d0 [Mina Lee] [DOC] Setting syntax highlight when writing new interpreter 20132ca [Mina Lee] Get paragraph editor mode from backend 52f4207 [Mina Lee] Align comments for readability 26cbbb8 [Mina Lee] Add editor field
### What is this PR for? This PR fixes broken layout of `Create new interpreter` UI. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1446 ### How should this be tested? - Try to create new interpreter on the Interpreters menu. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1431 from astroshim/ZEPPELIN-1446 and squashes the following commits: 729215b [astroshim] Merge branch 'master' into ZEPPELIN-1446 69cc1a0 [astroshim] Merge branch 'master' into ZEPPELIN-1446 fada36b [astroshim] fix spaces 2d3ec76 [astroshim] fix space 5f0a461 [astroshim] fix align checkboxs.
…reter ### What is this PR for? Livy will create SQLContext/HiveContext internally, (LIVY-94), so it is not necessary to create that in LivyInterpreter. Otherwise sqlContext in zeppelin will override that in livy. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1473 ### How should this be tested? Tested manually. HiveContext is created properly in livy (with proper livy configuration), and can access hive data. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #1450 from zjffdu/ZEPPELIN-1473 and squashes the following commits: bae46a1 [Jeff Zhang] ZEPPELIN-1473. It is not necessary to create SQLContext in LivyInterpreter
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md This is a rewrite of the "Quick Start" page, fixing syntax/grammar issues while trying to keep to the original content. I may look at other pages, but I wanted my first PR to be very small. ### What type of PR is it? Documentation ### Todos Verify the accuracy of the configuration settings section ### What is the Jira issue? (Does this apply to documentation PRs?) ### How should this be tested? Do documentation changes like this need to be tested? If so, is the github preview sufficient for these changes? How is Zeppelin's markdown interpreter different than Github's? If Github's MD preview isn't sufficient, is it possible to build the documentation locally? ### Screenshots (if appropriate) ### Questions: * Since this is my first PR on the project, I limited the scope of my changes. Is there any desire to change the content of these pages in any way? Do we have documentation conventions? Author: Roger Filmyer <[email protected]> Closes #1416 from rfilmyer/master and squashes the following commits: f2c126b [Roger Filmyer] Rewrite of "Quick Start"
### What is this PR for? #1395 changed alignment of html tag and it caused to make space between interpreter group and name. ### What type of PR is it? Bug Fix ### Screenshots (if appropriate) **Before** <img width="436" alt="screen shot 2016-09-22 at 11 31 35 am" src="https://cloud.githubusercontent.com/assets/8503346/18743269/7fa34b16-80b8-11e6-979a-194e7f6bef8f.png"> **After** <img width="411" alt="screen shot 2016-09-22 at 11 32 02 am" src="https://cloud.githubusercontent.com/assets/8503346/18743271/83807038-80b8-11e6-80b1-775c3369940e.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <[email protected]> Closes #1448 from minahlee/showInterpreterList and squashes the following commits: 5e2315a [Mina Lee] Remove space in available interpreters list
### What is this PR for? After #1416 merged, the bullet list in https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#installation isn't properly rendered now. It needs an extra newline. ### What type of PR is it? Hot Fix ### Screenshots (if appropriate) - Before <img width="834" alt="screen shot 2016-09-25 at 4 13 25 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813621/5e10c2dc-833b-11e6-8410-bb1d37d8228b.png"> - After <img width="834" alt="screen shot 2016-09-25 at 4 13 36 pm" src="https://cloud.githubusercontent.com/assets/10060731/18813622/6705b744-833b-11e6-8fab-3a69d8585c7a.png"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1457 from AhyoungRyu/fix/install.md and squashes the following commits: 73c1a4f [AhyoungRyu] Add a newline for bullet list markdown rendering
### What is this PR for?
`ZeppelinContext.show` doesn't work for spark 1.6. The root cause is that `Dataset` is also available in spark 1.6, so the following line will be false when cls is `Dataset` while o is `Dataframe` in spark 1.6
```
if (cls.isInstance(o)) {
```
This PR create a list of supported class and make it a member of `ZeppelinContext `so that we don't need to create it every time.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1427
### How should this be tested?
Tested it manually on spark 1.6 using the following sample code
```
z.show(sqlContext.sql("show tables"))
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <[email protected]>
Closes #1440 from zjffdu/ZEPPELIN-1427 and squashes the following commits:
62dbcad [Jeff Zhang] add unit test
a7ba67d [Jeff Zhang] ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1
…n is created ### What is this PR for? The issue is that we create 2 SparkSession in zeppelin_pyspark.py (Because we create SQLContext first which will create SparkSession underlying). This cause 2 instances of SparkSession in JVM side and this means we have 2 instances of Catalog as well. So udf registered in SQLContext can not be used in SparkSession. This PR will create SparkSession first and then assign its internal SQLContext to sqlContext in pyspark. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1442 ### How should this be tested? Integration test is added. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No … Author: Jeff Zhang <[email protected]> Closes #1452 from zjffdu/ZEPPELIN-1442 and squashes the following commits: a15e3c6 [Jeff Zhang] fix unit test 93060b6 [Jeff Zhang] ZEPPELIN-1442. UDF can not be found due to 2 instances of SparkSession is created
### What is this PR for?
If user specifies library path in interpreter dependency setting, even when the file on this path is updated, new file doesn't take effect on interpreter _restart_ but does only when user _clicks Edit -> Save._
The mechanism of dependency loading is copying all dependency libraries under `local-repo/
{interpreterId}` and add these directory to classpath of interpreter process. Zeppelin copies these dependencies either on Zeppelin startup or dependency saving/editing.
This PR checks if the library on specified local path is updated, and copy them to `local-repo/
{interpreterId}` on restart if there is change.
### What type of PR is it?
Bug Fix & Improvement
### What is the Jira issue?
[ZEPPELIN-1482](https://issues.apache.org/jira/browse/ZEPPELIN-1482)
### How should this be tested?
1. Download commons-csv-1.1.jar and commons-csv-1.2.jar to /my/path
2. cp commons-csv-1.2.jar /my/path/commons-csv.jar
3. Set dependency artifact of spark interpreter to /my/path/commons-csv.jar
4. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in paragraph and see if it runs without error
5. cp commons-csv-1.1.jar /my/path/commons-csv.jar
6. Restart spark interpreter
7. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in paragraph and see if error occurs.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Mina Lee <[email protected]>
Closes #1453 from minahlee/ZEPPELIN-1482 and squashes the following commits:
ea11664 [Mina Lee] Check if dependency library on specified path has changed and copy them under local-repo/{interpreterId} on interpreter restart
## What is this PR for? The PR is a interpreter for [Apache Beam](http://beam.incubator.apache.org) which is an open source unified platform for data processing pipelines. A pipeline can be build using one of the Beam SDKs. The execution of the pipeline is done by different Runners . Currently, Beam supports Apache Flink Runner, Apache Spark Runner, and Google Dataflow Runner. ### What type of PR is it? - Feature ### Todos * Test case * Review Comments * Documentation ### What is the Jira issue? * [ZEPPELIN-682] ### How should this be tested? - Start the Zeppelin server - The prefix of interpreter is `%beam` and then write your code with required imports and the runner ### Screenshots (if appropriate)   ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: mahmoudelgamal <[email protected]> Author: mfelgamal <[email protected]> Author: Fouad <[email protected]> Closes #1334 from mfelgamal/beam-interpreter-static-repl-7 and squashes the following commits: da66c27 [mahmoudelgamal] Modify condition of checking static modifier 55c1322 [mahmoudelgamal] set spark version to 1.6.2 and throw original exception 27d7690 [mahmoudelgamal] set spark version to 1.6.1 and some modifications 750041c [mahmoudelgamal] Add readme file and modify pom file and travis.yml ca88f94 [mahmoudelgamal] edit pom file and .travis.yml 3d65427 [mahmoudelgamal] update .travis.yml file f19f98d [mahmoudelgamal] Make easy example with imports ands some modifications 74c14ca [mahmoudelgamal] Update the licenses acc7afb [mahmoudelgamal] Change beam to version 0.2.0 e821614 [mahmoudelgamal] Removing hadoop-core and print stack trace to failure 5cb7c7b [mahmoudelgamal] Add some changes to doc and pom file 75fc4f7 [mahmoudelgamal] add interpreter to navigation.html and remove extra spaces and lines 9b1b385 [mahmoudelgamal] put beam in alphabetical order 9c1e25d [mahmoudelgamal] Adding changes like logging and conventions and license 2aa6d65 [mahmoudelgamal] changing class name to StaticRepl and adding some modifications 7cf25fb [mahmoudelgamal] Adding some tests 3c5038f [mahmoudelgamal] Modifying the documentation 5695077 [mahmoudelgamal] Modifying pom file and Making documentation 26fc59b [mahmoudelgamal] Refactoring of the code 3a2bd85 [mahmoudelgamal] Adding the beam to zeppelin 7 ab7ee2d [mahmoudelgamal] beam interpreter 85957ff [mfelgamal] Merge pull request #10 from apache/master 852c3d3 [mfelgamal] Merge pull request #9 from apache/master a4bcc0d [mfelgamal] Merge pull request #8 from apache/master 858f1e1 [mfelgamal] Merge pull request #7 from apache/master 03a1e80 [mfelgamal] Merge pull request #4 from apache/master 2586651 [Fouad] Merge pull request #2 from apache/master
…l error to user ### What is this PR for? This is about showing information to the user when there are errors on running paragraphs eg. there could be permission related issue with notebook. ### What type of PR is it? Improvement ### Todos NA ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-808 ### How should this be tested? * Create a notebook and change the file system permission for the notebook folder to have system level write permission to a different user.For eg. if you are running your local zeppelin server with id [USERNAME], then change the file system permission for one of your notebooks created with the former username to different one eg. ROOT user who will only have the write permission * Try to run all the paragraphs or any individual paragraph for the notebook * The information as shown in the screenshot should be displayed and the dialog could be closed by the 'Close' button. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kavin <[email protected]> Closes #1408 from kavinkumarks/zeppelin-808-handle-notebook-permission-error and squashes the following commits: 21fd49a [Kavin] Exit the run paragraph execution when there are errors with the notebook file system. 950ebda [Kavin] Handle FileSystemException on running paragraph and show the relevant error message to the user. 9f7cf67 [Kavin] Show information to the user when there are errors with related to permission on running paragraphs.
### What is this PR for? Phoenix has two different connection types: thick and thin. This PR is about describing the difference between the two and including properties for both in docs/interpreter/jdbc.md ### What type of PR is it? Documentation ### What is the Jira issue? [ZEPPELIN-1452](https://issues.apache.org/jira/browse/ZEPPELIN-1452) ### How should this be tested? No tests necessary ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Randy Gelhausen <[email protected]> Closes #1436 from randerzander/master and squashes the following commits: 3ed029e [Randy Gelhausen] Update jdbc.md 6e2dff0 [Randy Gelhausen] Update jdbc.md 2964ba8 [Randy Gelhausen] Update jdbc.md d2720c3 [Randy Gelhausen] tweaked jdbc readme 38b1692 [Randy Gelhausen] Updated JDBC docs to include Phoenix thin client
…broadcast ### What is this PR for? This PR addresses part of multi-user note management in Zeppelin. One of the tasks namely listing notes per user on Zeppelin start was addressed in #1330. However that PR didn't solve all problems, and reloading notes was incomplete as well as socket broadcast was not user aware [ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR addresses those issue. ### What type of PR is it? Improvement ### Todos * [x] - list notes per user on reload * [x] - broadcast per user (multicast) * [x] - tests * [x] - use authorization module to filter notes on sync * [x] - broadcast on permissions change * [ ] - discussion and review ### What is the Jira issue? [Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438) ### How should this be tested? 1. Start Zeppelin 2. Login as user1, and user2 on different windows 3. Each user should be able to see their own note workbench 4. If note changed to private (readers, writers not empty), that note should disappear from others note workbench. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: Khalid Huseynov <[email protected]> Closes #1392 from khalidhuseynov/feat/multi-user-notes and squashes the following commits: a2ce268 [Khalid Huseynov] broadcast note list on perm update - zeppelin-1438 9cf1d88 [Khalid Huseynov] fix init not to initialize every time 17eae84 [Khalid Huseynov] bugfix: add precondition for NP 781207e [Khalid Huseynov] bugfix: reload only once 537cc0e [Khalid Huseynov] apply filter from authorization in sync 09e6723 [Khalid Huseynov] notebookAuthorization as singleton 9427e62 [Khalid Huseynov] multicast fine grained note lists to users instead of broadcast 6614e2b [Khalid Huseynov] improve tests 1399407 [Khalid Huseynov] remove unused imports d9c3bc9 [Khalid Huseynov] filter reload using predicates 92f37f5 [Khalid Huseynov] substitute old getAllNotes(subject) with new implementation b7f19c9 [Khalid Huseynov] separate getAllNotes() and getAllNotes(subject) 17e2d4c [Khalid Huseynov] first draft
### What is this PR for? This is to resolve possible NPEs in storage mechanism related to empty subject ### What type of PR is it? Bug Fix ### Todos * [x] - pass `subject` instead of `null` ### What is the Jira issue? [ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487) ### How should this be tested? storage tests pass, CI green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1459 from khalidhuseynov/fix/storage-npe and squashes the following commits: 1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
…-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: rajarajan-g <[email protected]> Closes #1524 from rajarajan-g/ZEPPELIN-1542 and squashes the following commits: d97cb4a [rajarajan-g] code changes for ZEPPELIN-1542
…terpreter. ### What is this PR for? This PR fixes dependency library loading bug when creating new interpreter. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1534 ### How should this be tested? 1. Create new JDBC interpreter refer to http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html#mysql. 2. Create new paragraph for testing new JDBC interpreter. 3. Run paragraph. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <[email protected]> Closes #1507 from astroshim/ZEPPELIN-1534 and squashes the following commits: aebe352 [astroshim] add loadInterpreterDependencies function in createNewSetting()
### What is this PR for? The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations. But the result returned by Elasticsearch can contain more data according to the query. This PR is an improvement of the result returned by the interpreter. ### What type of PR is it? [Improvement] ### Todos * [X] - Dev of the improvement in the interpreter * [X] - Add a test case ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1537 ### How should this be tested? In a paragraph, enter a query with multiple aggregations: search /logs { "aggs" : { "length" : { "terms": { "field": "status" }, "aggs" : { "sum_length" : { "sum" : { "field" : "content_length" } } } } } ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Bruno Bonnin <[email protected]> Closes #1508 from bbonnin/master and squashes the following commits: a0a7bb9 [Bruno Bonnin] Elasticsearch improvement for results of aggregations
This PR replaces #1309 Author: Chris Snow <[email protected]> Closes #1531 from snowch/snowch-patch-1 and squashes the following commits: f5f7a70 [Chris Snow] use toString() method of CommandLine for logging 09a6d23 [Chris Snow] added missing semi-colon for statement 25e8a29 [Chris Snow] [ZEPPELIN-1314] dump out the R command
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: LantaoJin <[email protected]> Closes #1511 from LantaoJin/master and squashes the following commits: 671cd68 [LantaoJin] keep old py4j for backward compatibility 3bd84cc [LantaoJin] [ZEPPELIN-1544]upgrade spark version to 2.0.1 as profile spark-2.0
…tebooks ### What is this PR for? Currently, if you have a Notebook large number of, There is a sharp decrease in performance of the Code editor. The number and Paragraph creation of the Notebook does not have a relationship. We are should always use the Code editor of the same performance. I had to print a Notebook list only if there is a request. There was quite a lot of performance improvements. ### What type of PR is it? Improvement ### Todos - [x] - change Notebook list render logic ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1559 https://issues.apache.org/jira/browse/ZEPPELIN-1513 ### How should this be tested? 1. Create a notebook over 1000. (tested 10,000) I've used script on this. (important! please, backup for notebooks directory.) ``` #/bin/bash idx="0" while [ $idx -lt 1000 ] # notebooks count 1000 do mkdir $idx echo """ { \"paragraphs\": [ { \"text\": \"fsdkljfowiejfowejfoiwefiowejfiojlkdsjfklsdjflkjsdflkjwlkjefewf\", \"dateUpdated\": \"Oct 13, 2016 5:02:44 PM\", \"config\": { \"colWidth\": 12.0, \"graph\": { \"mode\": \"table\", \"height\": 300.0, \"optionOpen\": false, \"keys\": [], \"values\": [], \"groups\": [], \"scatter\": {}, \"map\": { \"baseMapType\": \"Streets\", \"isOnline\": true, \"pinCols\": [] } }, \"enabled\": true, \"editorMode\": \"ace/mode/scala\" }, \"settings\": { \"params\": {}, \"forms\": {} }, \"apps\": [], \"jobName\": \"paragraph_1476345687682_-1459653828\", \"id\": \"20161013-170127_68316618\", \"dateCreated\": \"Oct 13, 2016 5:01:27 PM\", \"status\": \"READY\", \"progressUpdateIntervalMs\": 500 } ], \"name\": \""${idx}"\", \"id\": \""${idx}"\", \"angularObjects\": { \"2BZSC9D3G:shared_process\": [], \"2BXGWF5TF:shared_process\": [], \"2BYKTADMA:shared_process\": [], \"2BYFT9HTZ:shared_process\": [], \"2BXDTJMED:shared_process\": [], \"2BZHPZ6NS:shared_process\": [], \"2BYKRWYB3:shared_process\": [], \"2BZH2UAT4:shared_process\": [], \"2BZ38J35G:shared_process\": [], \"2BXJ2X464:shared_process\": [], \"2BYQ57ED9:shared_process\": [], \"2BXDSA2SN:shared_process\": [], \"2BWZCTD2B:shared_process\": [], \"2BWT81MNU:shared_process\": [], \"2BWA7ZTRD:shared_process\": [], \"2BXW6X5KN:shared_process\": [], \"2BVWDQPXH:shared_process\": [], \"2BZGAF8KG:shared_process\": [] }, \"config\": {}, \"info\": {} } """ > $idx/note.json idx=$[$idx+1] done ``` 2. zeppelin restart or refresh notebook. 3. Try coding in any notebook. (fast) ### Screenshots (if appropriate) #### before ( 5000 notebooks)  #### after ( 5000 notebooks)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes #1533 from cloverhearts/ZEPPELIN-1559-Notebook-broadcast-opti and squashes the following commits: bd58102 [CloverHearts] id Delete unused for navbar 14e88bb [CloverHearts] selectively modified to render the Notebook list.
### What is this PR for? Enabling each user to run same interpreter. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1210 ### How should this be tested? 1. Enable shiro to use authentication mode 1. Check `per user` in your interpreter tab 1. Run different paragraphs with different users 1. Run `%spark sc.version`, you will see the two `res0: ...` in your paragraphs ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: CloverHearts <[email protected]> Author: Jongyoul Lee <[email protected]> Closes #1265 from jongyoul/ZEPPELIN-1210 and squashes the following commits: 48a0d8e [Jongyoul Lee] Fixed ZEPPELIN-1542 Fixed flaky test e84703d [Jongyoul Lee] Fixed ZEPPELIN-1542 ad80951 [Jongyoul Lee] Fixed some wrong logic of getInterpreterInstanceKey cee39f4 [Jongyoul Lee] Fixed to pass shiro information to InterpreterFactory from ZeppelinServer 5e7da34 [Jongyoul Lee] Changed instanceKey and processKey for dealing with new UI d201950 [CloverHearts] fix eqeqeq issue for frontweb b18bff4 [CloverHearts] implement frontend for interpreter per user mode and misc mode 1f64e52 [CloverHearts] change default value for pernote and peruser 787a366 [CloverHearts] change Back-end test cases and member type (perNote, perUser) 8586e1f [CloverHearts] change ui for interpreter running Per x mode 0b5d671 [Jongyoul Lee] Fixed the style 960bde1 [Jongyoul Lee] Removed SecurityUtils.getPrincipal Added fromMessage.principal to get right user 01c7cf1 [Jongyoul Lee] Fixed NPE while testing ZeppelinSparkClusterTest 1fb50ab [Jongyoul Lee] Fixed NPE while testing ZeppelinSparkClusterTest d1c4344 [Jongyoul Lee] Fixed getEditorSetting for having users' info 12a27db [Jongyoul Lee] Fixed test after rebase 510942b [Jongyoul Lee] Fixed test after rebase cb66946 [Jongyoul Lee] Fixed test after rebase 18b39bd [Jongyoul Lee] Fixed test after rebase daa634f [Jongyoul Lee] Fixed some tests after rebase ed558be [Jongyoul Lee] Fixed some tests after rebase fa7fccb [Jongyoul Lee] Fixed destroying process of remoteInterpreterProcess 0a73241 [Jongyoul Lee] Fixed conflict while rebasing. df423d3 [Jongyoul Lee] Fixed NotebookRestApiTest b151366 [Jongyoul Lee] Fixed some codes after rebase a32afd7 [Jongyoul Lee] Fixed some tests 7b7eb78 [Jongyoul Lee] Fixed some tests 47cc668 [Jongyoul Lee] Fixed tests to use AuthenticationInfo 012cf99 [Jongyoul Lee] Fixed some mismatch after rebase 9a03d40 [Jongyoul Lee] Reverted some value to default ones 8589545 [Jongyoul Lee] Added option in UI ccbedc1 [Jongyoul Lee] WIP 94dfed2 [Jongyoul Lee] WIP 6480d1d [Jongyoul Lee] resolved conflicts
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Author: Prabhjyot Singh <[email protected]> Closes #1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
…component" ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? Bug Fix ### Todos - [x] fix to text margin top - [x] implement to (per note / per user) setup feature of create new insterpreter ### How should this be tested? 1. on click interpreter menu. 2. on click interpreter menu. 3. check per user and per note setting. (`per user` setting must be shiro is activated) 4. save and check to result. ### Screenshots (if appropriate) #### - Create new Interpreter - before  #### - Create new Interpreter - after  #### - fix margin for interpreter settings - before  #### - fix margin for interpreter settings - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <[email protected]> Closes #1546 from cloverhearts/hotfix-inerpreterRunningModeUIFix and squashes the following commits: ebf1d81 [CloverHearts] hotfix - change setup ui for interpreter setting components
…s downloading dependencies ### What is this PR for? For first time, when we add dependencies for JDBC interpreter, dependencies will start getting downloaded in background. During that time, if user runs a paragraph of JDBC interpreter now user getting error , But instead paragraph execution should be put on 'PENDING' state and wait for dependencies to get downloaded and then run the paragraph ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? [ZEPPELIN-1488] https://issues.apache.org/jira/browse/ZEPPELIN-1488 ### How should this be tested? prerequisites: 1. Any DB setup.(For my testing, i considered hive) Steps: 1. Delete the local-repo folder under zeppelin project, if it exists 2. Go to interpreter settings page, provide hive connection details under JDBC interprepreter 3. For hive interpreter to run, it needs some dependencies to be added in interpreter settings page For hive below dependencies needs to added 1. org.apache.hive:hive-jdbc:0.14.0 2. org.apache.hadoop:hadoop-common:2.6.0 4. Once the settings for JDBC interpreter is saved, dependencies will start getting downloaded in background. 5. Run any paragraph with JDBC as interpreter, paragraph should not throw error, status of the paragraph should change to 'pending' while the dependencies are getting downloaded in background. 6. Once the downloading of dependencies is done, the paragraph which were in pending will start executing in order depending on the execution mode of the interpreter (i.e Shared, Scoped, Isolated) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: rajarajan-g <[email protected]> Closes #1467 from rajarajan-g/ZEPPELIN-1488 and squashes the following commits: b069328 [rajarajan-g] removed unnecessary method call ee98a84 [rajarajan-g] checkstyle fix c412dd6 [rajarajan-g] review fix 4f7b938 [rajarajan-g] code fix for ZEPPELIN-1488
### What is this PR for? Solve bug metioned [here](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L139) Since we launch python interpreter as a process and redirect stdin and stdout, only exception occurred (like syntax error or indentation error, etc) could give string like `...`. Thus, we don't need to determine whether syntax error happened in [`PythonProcess.sendAndGetResult`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonProcess.java#L86) because we have detected error in [`PythonInterpreter.pythonErrorIn`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L152) ### What type of PR is it? Bug Fix ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-1555 ### How should this be tested? Test locally. ### Screenshots <img width="1175" alt="screen shot 2016-10-16 at 18 05 00" src="https://cloud.githubusercontent.com/assets/3419881/19422552/192a8b3a-93cb-11e6-89e8-63f2652a7f85.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes #1530 from vectorijk/zeppelin-1555 and squashes the following commits: 8ffc360 [Kai Jiang] add unit test d7a2ef4 [Kai Jiang] [zeppelin-1555] Eliminate prefix in PythonInterpreter exception
### What is this PR for? Fix minor typos in docs ### What type of PR is it? Documentation ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: k <[email protected]> Author: Mina Lee <[email protected]> Author: laesunk <[email protected]> Closes #1542 from laesunk/fix_typo and squashes the following commits: 7b703a7 [laesunk] Merge pull request #1 from minahlee/fix_typo 28fc9ce [Mina Lee] Fix more typos a55ae4a [Mina Lee] Restore wrong changes during rebase 190ac05 [k] fix words 01ce71b [k] fix likly
…uster.md ### What is this PR for? Add missing TOC(Table of Contents) in install_with_flink_and_spark_cluster.md ### What type of PR is it? Documentation ### What is the Jira issue? no Jira issue for this Author: oganizang <[email protected]> Closes #1543 from oganizang/master and squashes the following commits: 832410a [oganizang] First open source commit
### What is this PR for? This PR applies the new interpreter registration mechanism to Geode Oql interpreter. ### What type of PR is it? Improvement ### Todos Added `interpreter-setting.json` ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912 ### How should this be tested? Test locally. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes #1550 from vectorijk/zeppelin-912 and squashes the following commits: 5dfad61 [Kai Jiang] Apply new mechanism to GeodeOqlInterpreter
### What is this PR for? apply multi-tenancy for storage sync mechanism ### What type of PR is it? Bug Fix | Improvement ### Todos * [x] - broadcast on sync * [x] - set permissions for pulled notes * [x] - add test ### What is the Jira issue? [ZEPPELIN-1561](https://issues.apache.org/jira/browse/ZEPPELIN-1561) ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) green CI ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes #1537 from khalidhuseynov/improve/sync-multiuser and squashes the following commits: b3e6ed3 [Khalid Huseynov] add userAndRoles 0f2ade7 [Khalid Huseynov] reformat style bd1a44a [Khalid Huseynov] address comment + test 05afa2a [Khalid Huseynov] remove syncOnStart b104249 [Khalid Huseynov] add isAnonymous 1a54cc0 [Khalid Huseynov] set perms for pulling notes - make them private 585a675 [Khalid Huseynov] reload, sync and broadcast on login cd1c3fa [Khalid Huseynov] don't sync on start
### What is this PR for? * configuration sorting * remove tooltip in job menu * change repository infomation icon ### What type of PR is it? Improvement ### Screenshots (if appropriate) * configuration sorting before <img width="1440" alt="f6a547d6-9225-11e6-80ab-7632f1c3d6cb" src="https://cloud.githubusercontent.com/assets/9584854/19631867/d50001f8-99db-11e6-81fc-47de15a3561b.png"> after <img width="1440" alt="2016-10-24 11 21 18" src="https://cloud.githubusercontent.com/assets/9584854/19631896/1688513e-99dc-11e6-8a8a-b87b996858cd.png">  * remove tooltip in job menu before <img width="1049" alt="0da61c8a-9226-11e6-9124-a51d09f11913" src="https://cloud.githubusercontent.com/assets/9584854/19631909/2a5cd90a-99dc-11e6-92dd-9738924de361.png"> after <img width="1051" alt="14d95af8-9226-11e6-852f-142c63f12f3d" src="https://cloud.githubusercontent.com/assets/9584854/19631914/4c4a7216-99dc-11e6-9e39-c08640c49923.png">  * change repository information icon before <img width="1052" alt="23663618-9226-11e6-9600-cbcb10b9ee1a" src="https://cloud.githubusercontent.com/assets/9584854/19631919/5407de6c-99dc-11e6-8043-a73669695114.png"> after <img width="1038" alt="2016-10-24 11 24 41" src="https://cloud.githubusercontent.com/assets/9584854/19631951/8d6b592c-99dc-11e6-8de1-28e760a16ebf.png">  Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: baekhoseok <[email protected]> Closes #1555 from baekhoseok/minor_ui_fix and squashes the following commits: bf98a03 [baekhoseok] minor ui improvement cd4af65 [baekhoseok] minor ui improvement
### What is this PR for? This PR fixes wrong written NotebookID to NoteID. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1549 ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No Author: hyonzin <[email protected]> Author: 정현진 <[email protected]> Author: Mina Lee <[email protected]> Closes #1518 from hyonzin/ZEPPELIN-1549 and squashes the following commits: 2c5d461 [hyonzin] fix pullNoteID to pullNoteId f843abd [hyonzin] Fix missed line 22aecb3 [hyonzin] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1549 ac03666 [정현진] Merge pull request #1 from minahlee/ZEPPELIN-1549 8b3fffd [Mina Lee] Change notebook to note and fix indentation 000605f [hyonzin] Change clonedNotebookId to clonedNoteId 496695c [hyonzin] Change noteID to noteId 1e87463 [hyonzin] Remove tab indent 5647d37 [hyonzin] Rebase and solve conflicts 09bacd8 [hyonzin] Fix more lines unchanged 070bc2d [hyonzin] fix more in ZeppelinRestApiTest.java 24822a3 [hyonzin] Fix more code not changed (notebookIndex to noteSearchService) 4b4e1e8 [hyonzin] Fix detail (function's name) & Change some placeholder 429203d [hyonzin] Fix details & convention to camel 5fa270d [hyonzin] pull upstream master & fix some details 294bea5 [hyonzin] Fix some wrong written term: Notebook -> Note cc0d315 [hyonzin] Change NotebookID variable name to NoteID
### What is this PR for? Since ZEPPELIN-1162 (PR #1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes #1556 from vectorijk/minor-remove-comments and squashes the following commits: 1e8ce8a [Kai Jiang] remove TODO comments since 1162 has been solved
What is this PR for? The URL for running a paragraph synchronously using REST api is mistakenly given as "http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] " Changed the doc as per code What type of PR is it? [Documentation] Todos What is the Jira issue? ZEPPELIN-1562 How should this be tested? Hit the url in below format for asynchrnous http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId] the same in synchronous http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId] Screenshots (if appropriate) Questions: Does the licenses files need update? NO Is there breaking changes for older versions? NO Does this needs documentation? NO Author: Naveen Subramanian <[email protected]> Closes #1560 from snaveenp/ZEPPELIN-1562-api-doc and squashes the following commits: 169d9b6 [Naveen Subramanian] updated api doc
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [ Documentation ] ### Todos * [x] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? spelling error responce => response seprated => separated Author: terrylee <[email protected]> Author: Mina Lee <[email protected]> Closes #1544 from hunylee/patch-1 and squashes the following commits: 1095a19 [terrylee] Merge pull request #1 from minahlee/fix_typo 9c26998 [terrylee] correct separated 1a3e187 [Mina Lee] fix typo 0490435 [terrylee] spelling error
### What is this PR for? This PR fix several issues of LivyInterpeter test. * Livy interpreter's test code is not in the right place, so it never runs. * LivyHelperTest would fail. * No Integration test for LivyInterpreter so any following change is not easy to be tested. This PR would fix the above issues. Regarding the integration test, some of livy's artifact is not available in repository, so I have to copy them to livy/local-maven-repo as local repository. And LivyInterperter's integration test require spark and livy to be installed. For now you have to download spark and livy manually. Please use spark 1.5.x and livy 0.2 which is currently supported. Download livy 0.2.0 from here [https://github.com/cloudera/livy/releases](https://github.com/cloudera/livy/releases) And use the following command to execute the LivyIntegrationTest. ``` export SPARK_HOME=<path_to_spark> export LIVY_HOME=<path_to_livy> mvn clean package -pl 'livy' -Dtest=LivyIntegrationTest ``` If you hit any issues, you can check logs under `livy/target/tmp`. ### What type of PR is it? [Bug Fix | Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1477 ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #1462 from zjffdu/ZEPPELIN-1477 and squashes the following commits: 75914b9 [Jeff Zhang] remove livy local jars fee61f9 [Jeff Zhang] add more test 1b9fbbc [Jeff Zhang] add missing dependencies e8ceff5 [Jeff Zhang] add missing livy jars 8632466 [Jeff Zhang] fix rat check f560a92 [Jeff Zhang] ZEPPELIN-1477. Add Integration Test for LivyInterpreter
### What is this PR for? The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without restarting Apache Zeppelin. This is flexible enough to handle most of the basic needs, but more complex case can be added in the future. I will not implement all NotebookRepo, this should be done in different PR since it will depend on special needs. I will just provide a simple example with VFS notebook repo. ***NB***: this scope of the PR doesn't include save change in the configuration file of zeppelin as well as implementation of every notebook repo, git, s3 etcetc, this will be added later if needed. ### What type of PR is it? * **Improvement** ### Todos * [x] - Implement backend. * [x] - Implement frontend. * [x] - Implement LocalVFS directory change as exemple. ### What is the Jira issue? * [ZEPPELIN-1575](https://issues.apache.org/jira/browse/ZEPPELIN-1575) ### How should this be tested? Go to notebook repo setting page, edit the notebook path and save. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? YES Author: Anthony Corbacho <[email protected]> Author: Damien CORNEAU <[email protected]> Closes #1553 from anthonycorbacho/feat/NotebookRepoSettings and squashes the following commits: 6d63832 [Anthony Corbacho] Fix style and rebase mistake... 6f17b18 [Anthony Corbacho] Add tests :: API and REST API 23ad18e [Anthony Corbacho] Rename NotebookRepoSettings to NotebookRepoSettingsInfo 42fd3b5 [Anthony Corbacho] Apply broadcasting note list after sucessful update for notebook repo 7fc1f37 [Anthony Corbacho] Change textarea size to 100 row 357b659 [Anthony Corbacho] Fix ASF header d49bfe1 [Anthony Corbacho] Fix style 517ebc8 [Anthony Corbacho] Fix style dc7fc50 [Anthony Corbacho] Fix indentation 0b4b74a [Anthony Corbacho] Add exemple of how to change local notebook repo FS 2d67bc8 [Anthony Corbacho] Added method from notebook repo interface 5a13e62 [Anthony Corbacho] Added 2 new methos in notebookRepoSync, exposed get and update notebook repo 8e890d3 [Anthony Corbacho] Add new wrapper for notebook repo PLUS settings 53346d7 [Anthony Corbacho] Add new methods in notebookRepo :: get and set settings in notebook 23912ce [Anthony Corbacho] Added new wrapper class 4d745ab [Damien CORNEAU] Improve ux 05a64de [Damien CORNEAU] Improve edit repo 9c1f999 [Damien CORNEAU] Implement edit 6a97512 [Damien CORNEAU] Get Repos from api 76479b3 [Damien CORNEAU] Change presentation of notebook settings 8075b04 [Damien CORNEAU] Render mocked list of notebook repo settings 054d2aa [Damien CORNEAU] Base structure for notebook repo ui 30d29cd [Anthony Corbacho] Update zeppelin server and add NotebookRepo rest api to the singleton f7c7bf2 [Anthony Corbacho] Update method :: updateRepoSettings to create NotebookRepoSettingsRequest with Empty static object instead of null a4d9749 [Anthony Corbacho] Added utility class for notebook re po payload deserialization efe4c34 [Anthony Corbacho] Add new Rest api endpoint for notebook Repo settings
pedrozatta
pushed a commit
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Several changes on doc of spark interpreter. * %spark, %sql, %pyspark only works when spark is the default interpreter group of note. So I update the doc to use the full interpreter name. * Add SparkSession for 2.0 * Also add comments inline with other changes to explain the reason. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <[email protected]> Author: Jeff Zhang <[email protected]> Author: Jeff Zhang <[email protected]> Closes apache#1398 from zjffdu/spark_doc_fix and squashes the following commits: ac01f2b [Jeff Zhang] Merge pull request #1 from AhyoungRyu/spark_doc_fix/ahyoung 5fa523f [AhyoungRyu] Fix typos 3c0f678 [AhyoungRyu] Add 'R' and refine a sentence 2336900 [AhyoungRyu] Improve spark.md 40d4b11 [Jeff Zhang] [MINOR] Doc fix for spark interpreter
pedrozatta
pushed a commit
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes apache#1469 from corneadoug/ZEPPELIN-1496 and squashes the following commits: 966cb27 [Damien CORNEAU] refactor components controllers 1807cf6 [Damien CORNEAU] Refactor components directives 0055191 [Damien CORNEAU] Refactor components service and factory f86adb4 [Damien CORNEAU] Finish refactoring of App 409c65c [Damien CORNEAU] IIFE refactoring of job page 4c45e08 [Damien CORNEAU] Refactor for IIFE credential, home and interpreter controller 7e88eef [Damien CORNEAU] Add congiguration.controller.js 6adb522 [Damien CORNEAU] Move use strict outside IFFE ffba0f3 [Damien CORNEAU] Add IIFE to app.controller.js
pedrozatta
pushed a commit
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Fix minor typos in docs ### What type of PR is it? Documentation ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: k <[email protected]> Author: Mina Lee <[email protected]> Author: laesunk <[email protected]> Closes apache#1542 from laesunk/fix_typo and squashes the following commits: 7b703a7 [laesunk] Merge pull request #1 from minahlee/fix_typo 28fc9ce [Mina Lee] Fix more typos a55ae4a [Mina Lee] Restore wrong changes during rebase 190ac05 [k] fix words 01ce71b [k] fix likly
pedrozatta
pushed a commit
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This PR fixes wrong written NotebookID to NoteID. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1549 ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No Author: hyonzin <[email protected]> Author: 정현진 <[email protected]> Author: Mina Lee <[email protected]> Closes apache#1518 from hyonzin/ZEPPELIN-1549 and squashes the following commits: 2c5d461 [hyonzin] fix pullNoteID to pullNoteId f843abd [hyonzin] Fix missed line 22aecb3 [hyonzin] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1549 ac03666 [정현진] Merge pull request #1 from minahlee/ZEPPELIN-1549 8b3fffd [Mina Lee] Change notebook to note and fix indentation 000605f [hyonzin] Change clonedNotebookId to clonedNoteId 496695c [hyonzin] Change noteID to noteId 1e87463 [hyonzin] Remove tab indent 5647d37 [hyonzin] Rebase and solve conflicts 09bacd8 [hyonzin] Fix more lines unchanged 070bc2d [hyonzin] fix more in ZeppelinRestApiTest.java 24822a3 [hyonzin] Fix more code not changed (notebookIndex to noteSearchService) 4b4e1e8 [hyonzin] Fix detail (function's name) & Change some placeholder 429203d [hyonzin] Fix details & convention to camel 5fa270d [hyonzin] pull upstream master & fix some details 294bea5 [hyonzin] Fix some wrong written term: Notebook -> Note cc0d315 [hyonzin] Change NotebookID variable name to NoteID
pedrozatta
pushed a commit
that referenced
this pull request
Oct 27, 2016
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [ Documentation ] ### Todos * [x] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? spelling error responce => response seprated => separated Author: terrylee <[email protected]> Author: Mina Lee <[email protected]> Closes apache#1544 from hunylee/patch-1 and squashes the following commits: 1095a19 [terrylee] Merge pull request #1 from minahlee/fix_typo 9c26998 [terrylee] correct separated 1a3e187 [Mina Lee] fix typo 0490435 [terrylee] spelling error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions: