-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-1483] Zeppelin home page list notebooks doesn't show notebook with group permission #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6a5aea to
d3261c4
Compare
|
Ready for review. |
| import java.io.IOException; | ||
| import java.io.StringReader; | ||
| import java.util.*; | ||
| import java.util.concurrent.TimeUnit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed if we include java.util.*
| import org.apache.zeppelin.user.AuthenticationInfo; | ||
| import org.apache.zeppelin.user.Credentials; | ||
| import org.quartz.*; | ||
| import org.quartz.impl.StdSchedulerFactory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed if we include org.quartz.*
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import javax.ws.rs.*; | ||
| import javax.ws.rs.core.Response; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed if we include javax.ws.rs.*
|
Thank you @corneadoug, have fixed it. |
|
adding group permissions to listed notes makes sense. tested and works as expected. maybe would makes sense to add integration tests to differentiate the cases of user and groups, maybe in different PR as improvement. CI looks irrelevant, LGTM |
|
Merging this if no more discussion. |
# Conflicts: # zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java # zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Author: Prabhjyot Singh <[email protected]> Closes apache#1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
…ok with group permission ### What is this PR for? Zeppelin home page list notebooks doesn't show notebook with group permission ### What type of PR is it? [Bug Fix] ### Todos * [x] - consume userAndRole instead of AuthenticationInfo ### What is the Jira issue? * [ZEPPELIN-1483](https://issues.apache.org/jira/browse/ZEPPELIN-1483) ### How should this be tested? In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed. IMO the notebook with group permission should also be listed in the home screen. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Author: Prabhjyot Singh <[email protected]> Closes apache#1454 from prabhjyotsingh/ZEPPELIN-1483 and squashes the following commits: 2484833 [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-1483 c8d810e [Prabhjyot Singh] organise imports d3261c4 [Prabhjyot Singh] consume userAndRole instead of AuthenticationInfo
What is this PR for?
Zeppelin home page list notebooks doesn't show notebook with group permission
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
In current scenario only those notebook lists that have direct user permission, those with group does not list up, but if user have link to those notebook, it can still be accessed.
IMO the notebook with group permission should also be listed in the home screen.
Screenshots (if appropriate)
Questions: