[MINOR] Hide "Currently there are no properties ~" msg & "edit", "restart" and "remove" btn in edit mode #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneadoug
reviewed
Sep 19, 2016
| <textarea ng-if="valueform.$visible" ng-model="dep.exclusions" | ||
| placeholder="(Optional) comma separated groupId:artifactId list" | ||
| form="valueform" | ||
| e-form="valueform" |
Contributor
There was a problem hiding this comment.
No e-form is needed here,
Actually the e-msd-elastic below should also be msd-elastic
those e-properties are only necessary in elements like editable-text
Contributor
Author
There was a problem hiding this comment.
@corneadoug Ah didn't know that. I'm using IntelliJ now, it said like below for form="valueform".
Anyway I reverted it :)
Contributor
|
tested, except for the comment, LGTM |
Contributor
|
@AhyoungRyu Test, Nice Improvements |
AhyoungRyu
force-pushed
the
fix/editMode
branch
from
08843aa to
4433f86
Compare
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…tart" and "remove" btn in edit mode ### What is this PR for? "Currently there are no properties and dependencies set for this interpreter" message is shown when there are no properties & dependencies in interpreter setting page. But this message can be seen even in the edit mode. It's quite wired. This message needs to be shown only in non-editable mode. The `edit`, `restart` and `remove` button are same. - `edit` button doesn't do any work after changing to edit mode - `restart` button: it doesn't make sense that someone is editing and restarting interpreter at the same time - `remove` button: Maybe someone wants to remove the interpreter while he is editing the interpreter. But it would be better this button is shown only in non-editable mode for the consistency with the other buttons. For the above reasons, I changed those buttons to be shown in non-editable mode only. `Save` & `Cancel` buttons are enough to the edit page I think. Please see the attached gif image. ### What type of PR is it? Bug Fix ### What is the Jira issue? ### How should this be tested? 1. After applying this patch and build only `zeppelin-web` with `./grunt build` under `zeppelin-web`. 2. You can quickly check this change in dev mode with `./grunt serve`. 3. Go to `Interpreter` menu and click "edit" button on Angular interpreter to see "Currently there are no properties and dependencies set for this interpreter" message. Can also check the existence of `edit`, `restart` and `remove` buttons. ### Screenshots (if appropriate) - Before  - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Author: AhyoungRyu <[email protected]> Closes apache#1434 from AhyoungRyu/fix/editMode and squashes the following commits: 4433f86 [AhyoungRyu] Make same width 'properties'&'dependencies' table 2e50f5d [AhyoungRyu] Revert 'form' 0c6c937 [AhyoungRyu] Fix minor issues in interpreter setting edit mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
"Currently there are no properties and dependencies set for this interpreter" message is shown when there are no properties & dependencies in interpreter setting page. But this message can be seen even in the edit mode. It's quite wired. This message needs to be shown only in non-editable mode.
The
edit,restartandremovebutton are same.editbutton doesn't do any work after changing to edit moderestartbutton: it doesn't make sense that someone is editing and restarting interpreter at the same timeremovebutton: Maybe someone wants to remove the interpreter while he is editing the interpreter. But it would be better this button is shown only in non-editable mode for the consistency with the other buttons.For the above reasons, I changed those buttons to be shown in non-editable mode only.
Save&Cancelbuttons are enough to the edit page I think. Please see the attached gif image.What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
zeppelin-webwith./grunt buildunderzeppelin-web../grunt serve.Interpretermenu and click "edit" button on Angular interpreter to see "Currently there are no properties and dependencies set for this interpreter" message. Can also check the existence ofedit,restartandremovebuttons.Screenshots (if appropriate)
Questions: