[ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpreter #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the contribution. LGTM. |
Contributor
Author
|
@jongyoul Thanks for the review! |
Contributor
Author
|
@jongyoul Thanks for the review! On Sat, Oct 22, 2016, 09:05 Jongyoul Lee [email protected] wrote:
|
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This PR applies the new interpreter registration mechanism to Geode Oql interpreter. ### What type of PR is it? Improvement ### Todos Added `interpreter-setting.json` ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912 ### How should this be tested? Test locally. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes apache#1550 from vectorijk/zeppelin-912 and squashes the following commits: 5dfad61 [Kai Jiang] Apply new mechanism to GeodeOqlInterpreter
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This PR applies the new interpreter registration mechanism to Geode Oql interpreter. ### What type of PR is it? Improvement ### Todos Added `interpreter-setting.json` ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912 ### How should this be tested? Test locally. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kai Jiang <[email protected]> Closes apache#1550 from vectorijk/zeppelin-912 and squashes the following commits: 5dfad61 [Kai Jiang] Apply new mechanism to GeodeOqlInterpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR applies the new interpreter registration mechanism to Geode Oql interpreter.
What type of PR is it?
Improvement
Todos
Added
interpreter-setting.jsonWhat is the Jira issue?
Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912
How should this be tested?
Test locally.
Screenshots (if appropriate)
Questions: