[ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission #1330

mwkang · 2016-08-13T07:54:36Z

What is this PR for?

If logged in user does not have Read and Write permission for a notebook, user should not see the notebook in the zeppelin home page.

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1144

How should this be tested?

unit test
online test

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

mwkang · 2016-08-16T04:23:36Z

CI error

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 76.102 sec - in org.apache.zeppelin.integration.SparkParagraphIT

Results :

Tests in error: 
  ZeppelinIT.testAngularDisplay:118->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 쨩 Timeout
  AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait:96 쨩 Timeout

Tests run: 15, Failures: 0, Errors: 2, Skipped: 0

bzz · 2016-08-16T07:05:24Z

Thank you for fixing it @mwkang

CI failure looks somehow relevant, you can not reproduce it locally?

mwkang · 2016-08-16T09:23:01Z

@bzz I will check it. Thanks for review.
When I fix CI, I'll mention you.

mwkang · 2016-08-20T07:19:47Z

@bzz #1330 (comment) It did not reproduce in local. Can you check this?

bzz · 2016-09-02T07:55:04Z

@mwkang could you please try close and then re-open this PR to trigger the CI and see if the same issue persists? Thanks!

\cc @khalidhuseynov for review.

khalidhuseynov · 2016-09-02T08:56:56Z

@mwkang thanks for the contribution! actually this is related to multi-user note management and there's some work going on under #1392 or #1390 .

In your case, i tested it, and there's a bit tricky moment with notes reloading and broadcasting. For example if you login as user1 with noteA and user2 with noteB and initially everything looks as expected, and then you reload your notes as shown below with refresh icon:

then if you refresh for user1 then noteA will appear in the list of all users, including user2 in our case. Same would happen if you reload for user2, meaning noteB will appear in the list of user1.

echarles · 2016-09-05T12:50:45Z

If the current single notebook-authorization.json is managed by user (with multiple files, and no more with a single one), how would you handle it?

khalidhuseynov · 2016-09-09T02:59:39Z

@mwkang could you re-trigger CI?

khalidhuseynov · 2016-09-13T06:10:16Z

I think it doesn't solve all problems, but definitely in the roadmap. LGTM

bzz · 2016-09-13T06:45:42Z

Thank you @mwkang @khalidhuseynov !

Will merge to master, if there is no further discussion.

Leemoonsoo · 2016-09-13T18:55:14Z

@mwkang @khalidhuseynov Could you handle or at least create issues for expected problems after merge this PR? I can at least think following two issues,

Note list broadcasting message is not aware user session, so notebook list can display notes that supposed to not see when other user refresh the notebook list.
When a user changes the permission of a note, note list need to be broadcasted immediately so all connected users can have updated list of notebook. Otherwise, there's still some chances that a user able to see some note on notebook list that they can not access.

khalidhuseynov · 2016-09-14T05:02:46Z

@Leemoonsoo issues are created under ZEPPELIN-1437 and ZEPPELIN-1438 correspondingly

Leemoonsoo · 2016-09-14T15:08:13Z

Thanks, Merge to master if there're no further discussions.

### What is this PR for? After #1330 merged, the latest master build failed with below compilation errors. ``` [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol symbol: method id() location: variable note1 of type org.apache.zeppelin.notebook.Note [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol symbol: method id() location: variable note2 of type org.apache.zeppelin.notebook.Note ``` ### What type of PR is it? Hot Fix ### What is the Jira issue? ### How should this be tested? - Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine` - Apply this patch and build with `mvn clean package -DskipTests` -> build success You can also check #1330 works properly. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1432 from AhyoungRyu/hotfix/ZEPPELIN-1144 and squashes the following commits: 6a3dbd3 [AhyoungRyu] Fix build error in Notebook.java

### What is this PR for? This started happening after ZEPPELIN-1144, #1330. This test (testGroupPermission) is to validate the group related permission on a notebook. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Fix CI ### What is the Jira issue? * [ZEPPELIN-1456](https://issues.apache.org/jira/browse/ZEPPELIN-1456) ### How should this be tested? CI xxx.10 (selenium) should be green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes #1444 from prabhjyotsingh/ZEPPELIN-1456 and squashes the following commits: 3c81587 [Prabhjyot Singh] ZEPPELIN-1456: fix

…broadcast ### What is this PR for? This PR addresses part of multi-user note management in Zeppelin. One of the tasks namely listing notes per user on Zeppelin start was addressed in #1330. However that PR didn't solve all problems, and reloading notes was incomplete as well as socket broadcast was not user aware [ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR addresses those issue. ### What type of PR is it? Improvement ### Todos * [x] - list notes per user on reload * [x] - broadcast per user (multicast) * [x] - tests * [x] - use authorization module to filter notes on sync * [x] - broadcast on permissions change * [ ] - discussion and review ### What is the Jira issue? [Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438) ### How should this be tested? 1. Start Zeppelin 2. Login as user1, and user2 on different windows 3. Each user should be able to see their own note workbench 4. If note changed to private (readers, writers not empty), that note should disappear from others note workbench. ### Screenshots (if appropriate) ![reload_broadcast](https://cloud.githubusercontent.com/assets/1642088/18679507/e4a0161c-7f9a-11e6-9d57-0930abf4b780.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: Khalid Huseynov <[email protected]> Closes #1392 from khalidhuseynov/feat/multi-user-notes and squashes the following commits: a2ce268 [Khalid Huseynov] broadcast note list on perm update - zeppelin-1438 9cf1d88 [Khalid Huseynov] fix init not to initialize every time 17eae84 [Khalid Huseynov] bugfix: add precondition for NP 781207e [Khalid Huseynov] bugfix: reload only once 537cc0e [Khalid Huseynov] apply filter from authorization in sync 09e6723 [Khalid Huseynov] notebookAuthorization as singleton 9427e62 [Khalid Huseynov] multicast fine grained note lists to users instead of broadcast 6614e2b [Khalid Huseynov] improve tests 1399407 [Khalid Huseynov] remove unused imports d9c3bc9 [Khalid Huseynov] filter reload using predicates 92f37f5 [Khalid Huseynov] substitute old getAllNotes(subject) with new implementation b7f19c9 [Khalid Huseynov] separate getAllNotes() and getAllNotes(subject) 17e2d4c [Khalid Huseynov] first draft

…broadcast ### What is this PR for? This PR addresses part of multi-user note management in Zeppelin. One of the tasks namely listing notes per user on Zeppelin start was addressed in apache#1330. However that PR didn't solve all problems, and reloading notes was incomplete as well as socket broadcast was not user aware [ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR addresses those issue. ### What type of PR is it? Improvement ### Todos * [x] - list notes per user on reload * [x] - broadcast per user (multicast) * [x] - tests * [x] - use authorization module to filter notes on sync * [x] - broadcast on permissions change * [ ] - discussion and review ### What is the Jira issue? [Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438) ### How should this be tested? 1. Start Zeppelin 2. Login as user1, and user2 on different windows 3. Each user should be able to see their own note workbench 4. If note changed to private (readers, writers not empty), that note should disappear from others note workbench. ### Screenshots (if appropriate) ![reload_broadcast](https://cloud.githubusercontent.com/assets/1642088/18679507/e4a0161c-7f9a-11e6-9d57-0930abf4b780.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: Khalid Huseynov <[email protected]> Closes apache#1392 from khalidhuseynov/feat/multi-user-notes and squashes the following commits: a2ce268 [Khalid Huseynov] broadcast note list on perm update - zeppelin-1438 9cf1d88 [Khalid Huseynov] fix init not to initialize every time 17eae84 [Khalid Huseynov] bugfix: add precondition for NP 781207e [Khalid Huseynov] bugfix: reload only once 537cc0e [Khalid Huseynov] apply filter from authorization in sync 09e6723 [Khalid Huseynov] notebookAuthorization as singleton 9427e62 [Khalid Huseynov] multicast fine grained note lists to users instead of broadcast 6614e2b [Khalid Huseynov] improve tests 1399407 [Khalid Huseynov] remove unused imports d9c3bc9 [Khalid Huseynov] filter reload using predicates 92f37f5 [Khalid Huseynov] substitute old getAllNotes(subject) with new implementation b7f19c9 [Khalid Huseynov] separate getAllNotes() and getAllNotes(subject) 17e2d4c [Khalid Huseynov] first draft

…d or write permission ### What is this PR for? If logged in user does not have Read and Write permission for a notebook, user should not see the notebook in the zeppelin home page. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1144 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Minwoo Kang <[email protected]> Closes apache#1330 from mwkang/ZEPPELIN-1144 and squashes the following commits: 82beb18 [Minwoo Kang] User see read, write, owner permission notebook.

### What is this PR for? After apache#1330 merged, the latest master build failed with below compilation errors. ``` [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol symbol: method id() location: variable note1 of type org.apache.zeppelin.notebook.Note [ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol symbol: method id() location: variable note2 of type org.apache.zeppelin.notebook.Note ``` ### What type of PR is it? Hot Fix ### What is the Jira issue? ### How should this be tested? - Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine` - Apply this patch and build with `mvn clean package -DskipTests` -> build success You can also check apache#1330 works properly. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes apache#1432 from AhyoungRyu/hotfix/ZEPPELIN-1144 and squashes the following commits: 6a3dbd3 [AhyoungRyu] Fix build error in Notebook.java

### What is this PR for? This started happening after ZEPPELIN-1144, apache#1330. This test (testGroupPermission) is to validate the group related permission on a notebook. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Fix CI ### What is the Jira issue? * [ZEPPELIN-1456](https://issues.apache.org/jira/browse/ZEPPELIN-1456) ### How should this be tested? CI xxx.10 (selenium) should be green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes apache#1444 from prabhjyotsingh/ZEPPELIN-1456 and squashes the following commits: 3c81587 [Prabhjyot Singh] ZEPPELIN-1456: fix

…broadcast ### What is this PR for? This PR addresses part of multi-user note management in Zeppelin. One of the tasks namely listing notes per user on Zeppelin start was addressed in apache#1330. However that PR didn't solve all problems, and reloading notes was incomplete as well as socket broadcast was not user aware [ZEPPELIN-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438). This PR addresses those issue. ### What type of PR is it? Improvement ### Todos * [x] - list notes per user on reload * [x] - broadcast per user (multicast) * [x] - tests * [x] - use authorization module to filter notes on sync * [x] - broadcast on permissions change * [ ] - discussion and review ### What is the Jira issue? [Zeppelin-1437](https://issues.apache.org/jira/browse/ZEPPELIN-1437), [ZEPPELIN-1438](https://issues.apache.org/jira/browse/ZEPPELIN-1438) ### How should this be tested? 1. Start Zeppelin 2. Login as user1, and user2 on different windows 3. Each user should be able to see their own note workbench 4. If note changed to private (readers, writers not empty), that note should disappear from others note workbench. ### Screenshots (if appropriate) ![reload_broadcast](https://cloud.githubusercontent.com/assets/1642088/18679507/e4a0161c-7f9a-11e6-9d57-0930abf4b780.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? yes Author: Khalid Huseynov <[email protected]> Closes apache#1392 from khalidhuseynov/feat/multi-user-notes and squashes the following commits: a2ce268 [Khalid Huseynov] broadcast note list on perm update - zeppelin-1438 9cf1d88 [Khalid Huseynov] fix init not to initialize every time 17eae84 [Khalid Huseynov] bugfix: add precondition for NP 781207e [Khalid Huseynov] bugfix: reload only once 537cc0e [Khalid Huseynov] apply filter from authorization in sync 09e6723 [Khalid Huseynov] notebookAuthorization as singleton 9427e62 [Khalid Huseynov] multicast fine grained note lists to users instead of broadcast 6614e2b [Khalid Huseynov] improve tests 1399407 [Khalid Huseynov] remove unused imports d9c3bc9 [Khalid Huseynov] filter reload using predicates 92f37f5 [Khalid Huseynov] substitute old getAllNotes(subject) with new implementation b7f19c9 [Khalid Huseynov] separate getAllNotes() and getAllNotes(subject) 17e2d4c [Khalid Huseynov] first draft

mwkang changed the title ~~[ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission~~ [WIP][ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission Aug 20, 2016

User see read, write, owner permission notebook.

82beb18

mwkang force-pushed the ZEPPELIN-1144 branch from 0a011db to 82beb18 Compare August 20, 2016 07:17

mwkang changed the title ~~[WIP][ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission~~ [ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission Aug 20, 2016

echarles mentioned this pull request Sep 5, 2016

[WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] Note and services per user #1390

Closed

6 tasks

Leemoonsoo mentioned this pull request Sep 13, 2016

[ZEPPELIN-1142] Zeppelin allows two users to simultaneously edit the notebook permissions #1393

Closed

asfgit closed this in 2902189 Sep 16, 2016

AhyoungRyu mentioned this pull request Sep 17, 2016

[HOT FIX][ZEPPELIN-1144] Fix compilation errors in Notebook.java #1432

Closed

khalidhuseynov mentioned this pull request Sep 17, 2016

[ZEPPELIN-1437, 1438] Multi-user note management - user aware reload broadcast #1392

Closed

6 tasks

prabhjyotsingh mentioned this pull request Sep 20, 2016

ZEPPELIN-1456: Flaky Test: AuthenticationIT #1444

Closed

1 task

[ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission #1330

[ZEPPELIN-1144]Zeppelin home page should only list notebooks with read or write permission #1330

Uh oh!

Conversation

mwkang commented Aug 13, 2016

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

mwkang commented Aug 16, 2016

Uh oh!

bzz commented Aug 16, 2016

Uh oh!

mwkang commented Aug 16, 2016

Uh oh!

mwkang commented Aug 20, 2016

Uh oh!

bzz commented Sep 2, 2016

Uh oh!

khalidhuseynov commented Sep 2, 2016

Uh oh!

echarles commented Sep 5, 2016

Uh oh!

khalidhuseynov commented Sep 9, 2016

Uh oh!

khalidhuseynov commented Sep 13, 2016

Uh oh!

bzz commented Sep 13, 2016

Uh oh!

Leemoonsoo commented Sep 13, 2016

Uh oh!

khalidhuseynov commented Sep 14, 2016

Uh oh!

Leemoonsoo commented Sep 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants