ZEPPELIN-1459: Zeppelin JDBC URL properties mangled #1442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhjyotsingh
force-pushed
the
ZEPPELIN-1459
branch
from
6d1ac9d to
906fe34
Compare
Contributor
|
I tested the PR and it works as expected. Thanks @prabhjyotsingh! |
Contributor
Author
|
Thank you @randerzander for quick verification, will merge this soon. |
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? While creating connection `DriverManager.getConnection(url, properties);` for JDBC interpreter, phoenix driver is modifying the properties that is passed as parameter, which in modifies propertiesMap. This all is resulting in, not able to execute any other paragraph with phoenix interpreter. This only happens if JDBC URI is "jdbc:phoenix:thin:url" ### What type of PR is it? [Bug Fix] ### Todos * [x] - Pass a copy of `properties` to `DriverManager.getConnection(url, properties)` ### What is the Jira issue? * [ZEPPELIN-1459](https://issues.apache.org/jira/browse/ZEPPELIN-1459) ### How should this be tested? Use the example setting below https://issues.apache.org/jira/browse/ZEPPELIN-1459?focusedCommentId=15505750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505750 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Prabhjyot Singh <[email protected]> Closes apache#1442 from prabhjyotsingh/ZEPPELIN-1459 and squashes the following commits: 906fe34 [Prabhjyot Singh] ZEPPELIN-1459: Zeppelin JDBC URL properties mangled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
While creating connection
DriverManager.getConnection(url, properties);for JDBC interpreter, phoenix driver is modifying the properties that is passed as parameter, which in modifies propertiesMap.This all is resulting in, not able to execute any other paragraph with phoenix interpreter.
This only happens if JDBC URI is "jdbc:phoenix:thin:url"
What type of PR is it?
[Bug Fix]
Todos
propertiestoDriverManager.getConnection(url, properties)What is the Jira issue?
How should this be tested?
Use the example setting below
https://issues.apache.org/jira/browse/ZEPPELIN-1459?focusedCommentId=15505750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15505750
Screenshots (if appropriate)
Questions: