[ZEPPELIN-1575] Notebook Repo settings UI #1553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonycorbacho
changed the title
Member
|
@anthonycorbacho thanks for suggesting to change repo settings via UI. before testing, do you think we need some unit tests for repo settings feature? |
Contributor
Author
|
@khalidhuseynov added some tests |
Contributor
Author
|
Please review this PR |
Contributor
Author
|
If no more discussion i am going to merge it. |
Member
|
@anthonycorbacho thanks for tests! tested and LGTM. |
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without restarting Apache Zeppelin. This is flexible enough to handle most of the basic needs, but more complex case can be added in the future. I will not implement all NotebookRepo, this should be done in different PR since it will depend on special needs. I will just provide a simple example with VFS notebook repo. ***NB***: this scope of the PR doesn't include save change in the configuration file of zeppelin as well as implementation of every notebook repo, git, s3 etcetc, this will be added later if needed. ### What type of PR is it? * **Improvement** ### Todos * [x] - Implement backend. * [x] - Implement frontend. * [x] - Implement LocalVFS directory change as exemple. ### What is the Jira issue? * [ZEPPELIN-1575](https://issues.apache.org/jira/browse/ZEPPELIN-1575) ### How should this be tested? Go to notebook repo setting page, edit the notebook path and save. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? YES Author: Anthony Corbacho <[email protected]> Author: Damien CORNEAU <[email protected]> Closes apache#1553 from anthonycorbacho/feat/NotebookRepoSettings and squashes the following commits: 6d63832 [Anthony Corbacho] Fix style and rebase mistake... 6f17b18 [Anthony Corbacho] Add tests :: API and REST API 23ad18e [Anthony Corbacho] Rename NotebookRepoSettings to NotebookRepoSettingsInfo 42fd3b5 [Anthony Corbacho] Apply broadcasting note list after sucessful update for notebook repo 7fc1f37 [Anthony Corbacho] Change textarea size to 100 row 357b659 [Anthony Corbacho] Fix ASF header d49bfe1 [Anthony Corbacho] Fix style 517ebc8 [Anthony Corbacho] Fix style dc7fc50 [Anthony Corbacho] Fix indentation 0b4b74a [Anthony Corbacho] Add exemple of how to change local notebook repo FS 2d67bc8 [Anthony Corbacho] Added method from notebook repo interface 5a13e62 [Anthony Corbacho] Added 2 new methos in notebookRepoSync, exposed get and update notebook repo 8e890d3 [Anthony Corbacho] Add new wrapper for notebook repo PLUS settings 53346d7 [Anthony Corbacho] Add new methods in notebookRepo :: get and set settings in notebook 23912ce [Anthony Corbacho] Added new wrapper class 4d745ab [Damien CORNEAU] Improve ux 05a64de [Damien CORNEAU] Improve edit repo 9c1f999 [Damien CORNEAU] Implement edit 6a97512 [Damien CORNEAU] Get Repos from api 76479b3 [Damien CORNEAU] Change presentation of notebook settings 8075b04 [Damien CORNEAU] Render mocked list of notebook repo settings 054d2aa [Damien CORNEAU] Base structure for notebook repo ui 30d29cd [Anthony Corbacho] Update zeppelin server and add NotebookRepo rest api to the singleton f7c7bf2 [Anthony Corbacho] Update method :: updateRepoSettings to create NotebookRepoSettingsRequest with Empty static object instead of null a4d9749 [Anthony Corbacho] Added utility class for notebook re po payload deserialization efe4c34 [Anthony Corbacho] Add new Rest api endpoint for notebook Repo settings
|
@anthonycorbacho thanks for your woker very much ! however,a little problem confused me. I am looking forward to getting your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without restarting Apache Zeppelin.
This is flexible enough to handle most of the basic needs, but more complex case can be added in the future. I will not implement all NotebookRepo, this should be done in different PR since it will depend on special needs. I will just provide a simple example with VFS notebook repo.
_NB_: this scope of the PR doesn't include save change in the configuration file of zeppelin as well as implementation of every notebook repo, git, s3 etcetc, this will be added later if needed.
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Go to notebook repo setting page, edit the notebook path and save.
Screenshots (if appropriate)
Questions: