[ZEPPELIN-1542] Cleanup of Note created during jUnit test in zeppelin-server, zeppelin-zengine #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
Author
|
Reopening the PR to trigger CI build |
ghost
reopened this
Member
|
Looks interesting! |
Member
|
LGTM! |
Member
|
doesn't |
Member
|
@khalidhuseynov If we already have own our notes, removing whole directory also removes our own. :-) |
Member
|
Yeah make sense, LGTM! |
Contributor
|
LGTM 👍 Thanks, |
Member
|
Merge to master if there're no more discussions. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
…-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: rajarajan-g <[email protected]> Closes apache#1524 from rajarajan-g/ZEPPELIN-1542 and squashes the following commits: d97cb4a [rajarajan-g] code changes for ZEPPELIN-1542
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…-server, zeppelin-zengine ### What is this PR for? While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1542 ### How should this be tested? Prerequisites: 1. Get the list of note that already exist in server. Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'). 1. Now no extra note should get created after running the maven command ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: rajarajan-g <[email protected]> Closes apache#1524 from rajarajan-g/ZEPPELIN-1542 and squashes the following commits: d97cb4a [rajarajan-g] code changes for ZEPPELIN-1542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
While running jUnit tests in zeppelin-server & zeppelin-zengine projects, several note are created during the process and those notes are never purged after the execution of the tests.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1542
How should this be tested?
Prerequisites:
Now build zeppelin project by running maven commands(mvn clean package)(mvn clean package -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server').
Screenshots (if appropriate)
Questions: