[ZEPPELIN-1537] Elasticsearch improvement for results of aggregations #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me, 👍 for tests! Merging if there is no further discussion. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations. But the result returned by Elasticsearch can contain more data according to the query. This PR is an improvement of the result returned by the interpreter. ### What type of PR is it? [Improvement] ### Todos * [X] - Dev of the improvement in the interpreter * [X] - Add a test case ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1537 ### How should this be tested? In a paragraph, enter a query with multiple aggregations: search /logs { "aggs" : { "length" : { "terms": { "field": "status" }, "aggs" : { "sum_length" : { "sum" : { "field" : "content_length" } } } } } ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Bruno Bonnin <[email protected]> Closes apache#1508 from bbonnin/master and squashes the following commits: a0a7bb9 [Bruno Bonnin] Elasticsearch improvement for results of aggregations
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations. But the result returned by Elasticsearch can contain more data according to the query. This PR is an improvement of the result returned by the interpreter. ### What type of PR is it? [Improvement] ### Todos * [X] - Dev of the improvement in the interpreter * [X] - Add a test case ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1537 ### How should this be tested? In a paragraph, enter a query with multiple aggregations: search /logs { "aggs" : { "length" : { "terms": { "field": "status" }, "aggs" : { "sum_length" : { "sum" : { "field" : "content_length" } } } } } ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Bruno Bonnin <[email protected]> Closes apache#1508 from bbonnin/master and squashes the following commits: a0a7bb9 [Bruno Bonnin] Elasticsearch improvement for results of aggregations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The result of an aggregation query returned by the interpreter contains only "key" and "doc_count" in case of a multi-buckets aggregations.
But the result returned by Elasticsearch can contain more data according to the query.
This PR is an improvement of the result returned by the interpreter.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1537
How should this be tested?
In a paragraph, enter a query with multiple aggregations:
search /logs { "aggs" : {
"length" : { "terms": { "field": "status" },
"aggs" : { "sum_length" : { "sum" : { "field" : "content_length" } } } } }
Screenshots (if appropriate)
Questions: