Skip to content

Conversation

@baekhoseok
Copy link
Contributor

@baekhoseok baekhoseok commented Oct 24, 2016

What is this PR for?

  • configuration sorting
  • remove tooltip in job menu
  • change repository infomation icon

What type of PR is it?

Improvement

Screenshots (if appropriate)

  • configuration sorting

before

f6a547d6-9225-11e6-80ab-7632f1c3d6cb

after
2016-10-24 11 21 18

  • remove tooltip in job menu

before

0da61c8a-9226-11e6-9124-a51d09f11913

after

14d95af8-9226-11e6-852f-142c63f12f3d

  • change repository information icon

before 

23663618-9226-11e6-9600-cbcb10b9ee1a

after
2016-10-24 11 24 41


Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? yes

@minahlee
Copy link
Member

Tested and LGTM. Merge if there is no more discussion.

@asfgit asfgit closed this in ba5a2d8 Oct 25, 2016
snaveenp pushed a commit to snaveenp/zeppelin that referenced this pull request Oct 25, 2016
### What is this PR for?
* configuration sorting
* remove tooltip in job menu
* change repository infomation icon

### What type of PR is it?
Improvement

### Screenshots (if appropriate)
* configuration sorting

before

<img width="1440" alt="f6a547d6-9225-11e6-80ab-7632f1c3d6cb" src="https://cloud.githubusercontent.com/assets/9584854/19631867/d50001f8-99db-11e6-81fc-47de15a3561b.png">

after
<img width="1440" alt="2016-10-24 11 21 18" src="https://cloud.githubusercontent.com/assets/9584854/19631896/1688513e-99dc-11e6-8a8a-b87b996858cd.png">

* remove tooltip in job menu

before

<img width="1049" alt="0da61c8a-9226-11e6-9124-a51d09f11913" src="https://cloud.githubusercontent.com/assets/9584854/19631909/2a5cd90a-99dc-11e6-92dd-9738924de361.png">

after

<img width="1051" alt="14d95af8-9226-11e6-852f-142c63f12f3d" src="https://cloud.githubusercontent.com/assets/9584854/19631914/4c4a7216-99dc-11e6-9e39-c08640c49923.png">


* change repository information icon

before 

<img width="1052" alt="23663618-9226-11e6-9600-cbcb10b9ee1a" src="https://cloud.githubusercontent.com/assets/9584854/19631919/5407de6c-99dc-11e6-8043-a73669695114.png">

after
<img width="1038" alt="2016-10-24 11 24 41" src="https://cloud.githubusercontent.com/assets/9584854/19631951/8d6b592c-99dc-11e6-8de1-28e760a16ebf.png">


Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes

Author: baekhoseok <[email protected]>

Closes apache#1555 from baekhoseok/minor_ui_fix and squashes the following commits:

bf98a03 [baekhoseok] minor ui improvement
cd4af65 [baekhoseok] minor ui improvement
darionyaphet pushed a commit to darionyaphet/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
* configuration sorting
* remove tooltip in job menu
* change repository infomation icon

### What type of PR is it?
Improvement

### Screenshots (if appropriate)
* configuration sorting

before

<img width="1440" alt="f6a547d6-9225-11e6-80ab-7632f1c3d6cb" src="https://cloud.githubusercontent.com/assets/9584854/19631867/d50001f8-99db-11e6-81fc-47de15a3561b.png">

after
<img width="1440" alt="2016-10-24 11 21 18" src="https://cloud.githubusercontent.com/assets/9584854/19631896/1688513e-99dc-11e6-8a8a-b87b996858cd.png">

* remove tooltip in job menu

before

<img width="1049" alt="0da61c8a-9226-11e6-9124-a51d09f11913" src="https://cloud.githubusercontent.com/assets/9584854/19631909/2a5cd90a-99dc-11e6-92dd-9738924de361.png">

after

<img width="1051" alt="14d95af8-9226-11e6-852f-142c63f12f3d" src="https://cloud.githubusercontent.com/assets/9584854/19631914/4c4a7216-99dc-11e6-9e39-c08640c49923.png">


* change repository information icon

before 

<img width="1052" alt="23663618-9226-11e6-9600-cbcb10b9ee1a" src="https://cloud.githubusercontent.com/assets/9584854/19631919/5407de6c-99dc-11e6-8043-a73669695114.png">

after
<img width="1038" alt="2016-10-24 11 24 41" src="https://cloud.githubusercontent.com/assets/9584854/19631951/8d6b592c-99dc-11e6-8de1-28e760a16ebf.png">


Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes

Author: baekhoseok <[email protected]>

Closes apache#1555 from baekhoseok/minor_ui_fix and squashes the following commits:

bf98a03 [baekhoseok] minor ui improvement
cd4af65 [baekhoseok] minor ui improvement
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
* configuration sorting
* remove tooltip in job menu
* change repository infomation icon

### What type of PR is it?
Improvement

### Screenshots (if appropriate)
* configuration sorting

before

<img width="1440" alt="f6a547d6-9225-11e6-80ab-7632f1c3d6cb" src="https://cloud.githubusercontent.com/assets/9584854/19631867/d50001f8-99db-11e6-81fc-47de15a3561b.png">

after
<img width="1440" alt="2016-10-24 11 21 18" src="https://cloud.githubusercontent.com/assets/9584854/19631896/1688513e-99dc-11e6-8a8a-b87b996858cd.png">

* remove tooltip in job menu

before

<img width="1049" alt="0da61c8a-9226-11e6-9124-a51d09f11913" src="https://cloud.githubusercontent.com/assets/9584854/19631909/2a5cd90a-99dc-11e6-92dd-9738924de361.png">

after

<img width="1051" alt="14d95af8-9226-11e6-852f-142c63f12f3d" src="https://cloud.githubusercontent.com/assets/9584854/19631914/4c4a7216-99dc-11e6-9e39-c08640c49923.png">


* change repository information icon

before 

<img width="1052" alt="23663618-9226-11e6-9600-cbcb10b9ee1a" src="https://cloud.githubusercontent.com/assets/9584854/19631919/5407de6c-99dc-11e6-8043-a73669695114.png">

after
<img width="1038" alt="2016-10-24 11 24 41" src="https://cloud.githubusercontent.com/assets/9584854/19631951/8d6b592c-99dc-11e6-8de1-28e760a16ebf.png">


Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes

Author: baekhoseok <[email protected]>

Closes apache#1555 from baekhoseok/minor_ui_fix and squashes the following commits:

bf98a03 [baekhoseok] minor ui improvement
cd4af65 [baekhoseok] minor ui improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants