Skip to content

Conversation

@snowch
Copy link
Contributor

@snowch snowch commented Aug 9, 2016

What is this PR for?

When diagnosing issues executing R, it would be useful to view the command that is being run so that command can be manually executed and debugged.

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

 dump out the R command to facilitate manually running it, e.g. for fault diagnosis purposes
@corneadoug
Copy link
Contributor

@snowch Sorry for the delay,
I'm actually not an R expert so I'm not sure what this change bring.

Could you maybe provide a paragraph code example or before/after screenshot example to understand a bit more?

Also you can probably rebase your branch to have a green CI

@zjffdu
Copy link
Contributor

zjffdu commented Sep 26, 2016

@snowch Not sure how much dumping out the R command would help diagnose. Do you meet any case that failed to launch the R process ? If you want to diagnose the R process after it is launched. You can refer SparkOutputStream which will print output in debug level. You just need add the following line in log4j.properties.

log4j.logger.org.apache.zeppelin.spark.SparkOutputStream=DEBUG

@snowch
Copy link
Contributor Author

snowch commented Oct 15, 2016

The R process launched, but I received an error. I would like to be able to execute the R command manually which is why I want to dump out how R is being called.

@Leemoonsoo
Copy link
Member

@snowch Thanks for explanation. Make sense.
CI is failing with

[INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-fail-build) @ zeppelin-spark_2.11 ---
/home/travis/build/apache/zeppelin/spark/src/main/java/org/apache/zeppelin/spark/ZeppelinR.java:148:5: unexpected token: executor
[INFO] 
[INFO] There are 1 checkstyle errors.
[ERROR] ZeppelinR.java[149:5] (extension) TreeWalker: Got an exception - expecting EOF, found 'outputStream'

Could you take a look and make CI green?

@snowch
Copy link
Contributor Author

snowch commented Oct 17, 2016

Damn, I had deleted my forked repository. I've created a new PR here: #1531

asfgit pushed a commit that referenced this pull request Oct 19, 2016
This PR replaces #1309

Author: Chris Snow <[email protected]>

Closes #1531 from snowch/snowch-patch-1 and squashes the following commits:

f5f7a70 [Chris Snow] use toString() method of CommandLine for logging
09a6d23 [Chris Snow] added missing semi-colon for statement
25e8a29 [Chris Snow] [ZEPPELIN-1314] dump out the R command
darionyaphet pushed a commit to darionyaphet/zeppelin that referenced this pull request Oct 27, 2016
This PR replaces apache#1309

Author: Chris Snow <[email protected]>

Closes apache#1531 from snowch/snowch-patch-1 and squashes the following commits:

f5f7a70 [Chris Snow] use toString() method of CommandLine for logging
09a6d23 [Chris Snow] added missing semi-colon for statement
25e8a29 [Chris Snow] [ZEPPELIN-1314] dump out the R command
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
This PR replaces apache#1309

Author: Chris Snow <[email protected]>

Closes apache#1531 from snowch/snowch-patch-1 and squashes the following commits:

f5f7a70 [Chris Snow] use toString() method of CommandLine for logging
09a6d23 [Chris Snow] added missing semi-colon for statement
25e8a29 [Chris Snow] [ZEPPELIN-1314] dump out the R command
@snowch snowch closed this Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants