ZEPPELIN-1452: Include Phoenix 'thin client' instructions in docs #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
changed the title
Fixed JDBC driver classname, included Phoenix 4.8 artifact name
made dependency selection clearer
Contributor
Author
|
Before merging and implying support for Phoenix's thin client, ZEPPELIN-1459 should also be resolved. |
AhyoungRyu
reviewed
Sep 20, 2016
| The thin client has fewer dependencies and connects through a [Phoenix Query Server](http://phoenix.apache.org/server.html) instance. | ||
|
|
||
| Use the appropriate phoenix.driver and phoenix.url for your connection type. | ||
|
|
Contributor
There was a problem hiding this comment.
Hi @randerzander. Thanks for your contribution!
Probably it's a nitpick, currently those 4 lines are rendered like below,
So how about changing the 4 lines to like this? (You can just copy&paste if you want :D )
Phoenix supports `thick` and `thin` connection types:
- Thick client is faster, but must connect directly to ZooKeeper and HBase RegionServers.
- Thin client has fewer dependencies and connects through a [Phoenix Query Server](http://phoenix.apache.org/server.html) instance.
Use the appropriate `phoenix.driver` and `phoenix.url` for your connection type.
Then it will be rendered
Contributor
Author
There was a problem hiding this comment.
Makes sense. I included your suggestion in the latest commit.
suggestion from AhyoungRyu
Member
|
LGTM |
Member
|
Merge if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2016
### What is this PR for? Phoenix has two different connection types: thick and thin. This PR is about describing the difference between the two and including properties for both in docs/interpreter/jdbc.md ### What type of PR is it? Documentation ### What is the Jira issue? [ZEPPELIN-1452](https://issues.apache.org/jira/browse/ZEPPELIN-1452) ### How should this be tested? No tests necessary ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Randy Gelhausen <[email protected]> Closes #1436 from randerzander/master and squashes the following commits: 3ed029e [Randy Gelhausen] Update jdbc.md 6e2dff0 [Randy Gelhausen] Update jdbc.md 2964ba8 [Randy Gelhausen] Update jdbc.md d2720c3 [Randy Gelhausen] tweaked jdbc readme 38b1692 [Randy Gelhausen] Updated JDBC docs to include Phoenix thin client (cherry picked from commit aff653b) Signed-off-by: Mina Lee <[email protected]>
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? Phoenix has two different connection types: thick and thin. This PR is about describing the difference between the two and including properties for both in docs/interpreter/jdbc.md ### What type of PR is it? Documentation ### What is the Jira issue? [ZEPPELIN-1452](https://issues.apache.org/jira/browse/ZEPPELIN-1452) ### How should this be tested? No tests necessary ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Randy Gelhausen <[email protected]> Closes apache#1436 from randerzander/master and squashes the following commits: 3ed029e [Randy Gelhausen] Update jdbc.md 6e2dff0 [Randy Gelhausen] Update jdbc.md 2964ba8 [Randy Gelhausen] Update jdbc.md d2720c3 [Randy Gelhausen] tweaked jdbc readme 38b1692 [Randy Gelhausen] Updated JDBC docs to include Phoenix thin client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Phoenix has two different connection types: thick and thin.
This PR is about describing the difference between the two and including properties for both in docs/interpreter/jdbc.md
What type of PR is it?
Documentation
What is the Jira issue?
ZEPPELIN-1452
How should this be tested?
No tests necessary
Questions:
No
No
No