[ZEPPELIN-1487] Resolve possible NPEs in storage sync mechanism #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidhuseynov
changed the title
khalidhuseynov
force-pushed
the
fix/storage-npe
branch
3 times, most recently
from
6c79617 to
ba7a0c9
Compare
khalidhuseynov
force-pushed
the
fix/storage-npe
branch
from
ba7a0c9 to
1f2dcd3
Compare
Member
Author
|
ping |
Member
|
LGTM and merge if there're no more discussions. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This is to resolve possible NPEs in storage mechanism related to empty subject ### What type of PR is it? Bug Fix ### Todos * [x] - pass `subject` instead of `null` ### What is the Jira issue? [ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487) ### How should this be tested? storage tests pass, CI green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes apache#1459 from khalidhuseynov/fix/storage-npe and squashes the following commits: 1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? This is to resolve possible NPEs in storage mechanism related to empty subject ### What type of PR is it? Bug Fix ### Todos * [x] - pass `subject` instead of `null` ### What is the Jira issue? [ZEPPELIN-1487](https://issues.apache.org/jira/browse/ZEPPELIN-1487) ### How should this be tested? storage tests pass, CI green ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Closes apache#1459 from khalidhuseynov/fix/storage-npe and squashes the following commits: 1f2dcd3 [Khalid Huseynov] pass subject to get method in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is to resolve possible NPEs in storage mechanism related to empty subject
What type of PR is it?
Bug Fix
Todos
subjectinstead ofnullWhat is the Jira issue?
ZEPPELIN-1487
How should this be tested?
storage tests pass, CI green
Screenshots (if appropriate)
Questions: