[ZEPPELIN-1544]upgrade spark version to 2.0.1 as profile spark-2.0 #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Merging if there's no more discussion. |
Leemoonsoo
reviewed
Oct 14, 2016
| //Only one of py4j-0.9-src.zip and py4j-0.8.2.1-src.zip should exist | ||
| String[] pythonLibs = new String[]{"pyspark.zip", "py4j-0.9-src.zip", "py4j-0.8.2.1-src.zip", | ||
| "py4j-0.10.1-src.zip"}; | ||
| "py4j-0.10.3-src.zip"}; |
Member
There was a problem hiding this comment.
Shouldn't "py4j-0.10.1-src.zip" need to be in the array for in case of spark 2.0.0?
Member
There was a problem hiding this comment.
You're right. My mistake. We need to keep old py4j for backward compatibility. I've checked that 2.0.0 has python/lib/py4j-0.10.1-src.zip
Contributor
Author
There was a problem hiding this comment.
You means that add "py4j-0.10.3-src.zip" after "py4j-0.10.1-src.zip"? Can it confuse the logic below?
// Distribute two libraries(pyspark.zip and py4j-*.zip) to workers
// when spark version is less than or equal to 1.4.1
if (pythonLibUris.size() == 2) {
If this semantics is the same as before adding. I will follow your comment to modify.
Member
|
@LantaoJin Can you edit your description following the guide? |
1 task
Member
|
Thanks @LantaoJin for the contribution. LGTM and merge if there're no more discussions. |
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: LantaoJin <[email protected]> Closes apache#1511 from LantaoJin/master and squashes the following commits: 671cd68 [LantaoJin] keep old py4j for backward compatibility 3bd84cc [LantaoJin] [ZEPPELIN-1544]upgrade spark version to 2.0.1 as profile spark-2.0
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: LantaoJin <[email protected]> Closes apache#1511 from LantaoJin/master and squashes the following commits: 671cd68 [LantaoJin] keep old py4j for backward compatibility 3bd84cc [LantaoJin] [ZEPPELIN-1544]upgrade spark version to 2.0.1 as profile spark-2.0
asfgit
pushed a commit
that referenced
this pull request
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Outline the steps to test the PR here.
Screenshots (if appropriate)
Questions: