[ZEPPELIN-1182] Zeppelin should have Startup and Shutdown message #1399
Conversation
|
Done or WIP? |
|
I am logging the configuration details of Zeppelin . I am not sure if we have any more configuration details to be logged. Please check PR and let me know if any more configuration needs to be added. |
|
@ALL: Please do review and let me know your opnion |
|
Ping |
Leemoonsoo
left a comment
Leemoonsoo
left a comment
There was a problem hiding this comment.
Thanks @rajarajan-g for the contribution.
I think the message can be printed in ${ZEPPELIN_OUTFILE} instead of ${ZEPPELIN_LOGFILE}. Then there will be no concern for log message format. And i think it's better print log message before Zeppelin process starts and the process holds both ${ZEPPELIN_OUTFILE} and ${ZEPPELIN_LOGFILE} files open.
bin/zeppelin-daemon.sh
Outdated
| wait_zeppelin_is_up_for_ci | ||
| sleep 2 | ||
| check_if_process_is_alive | ||
| echo "ZEPPELIN_CLASSPATH: ${ZEPPELIN_CLASSPATH}" >> "${ZEPPELIN_LOGFILE}" |
There was a problem hiding this comment.
I think printing entire classpath i.e $ZEPPELIN_CLASSPATH_OVERRIDES:$CLASSPATH is more make sense. what do you think?
There was a problem hiding this comment.
Sure.
But one quick question, Do we really set or use ZEPPELIN_CLASSPATH_OVERRIDES ? I don't see any assignment operation on that property. Please let me know if i am missing something.
There was a problem hiding this comment.
Yes, classpath includes, ZEPPELIN_CLASSPATH_OVERRIDES https://github.com/apache/zeppelin/blob/master/bin/zeppelin-daemon.sh#L180
https://github.com/apache/zeppelin/blob/master/bin/interpreter.sh#L161
|
It makes more sense to have message logged in |
|
CI failure is irrelevant. |
### What is this PR for? PR is for logging configuration details of Zeppelin server. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1182 ### How should this be tested? Please check the log if information on Server host, server path, context path, zeppelin version, class path is available in that file. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Note: For configuration details such as zeppelin version, server host, port & context path , these are available as part of zeppelin configuration. Logging information ``` INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:107) - Server Host: 0.0.0.0 INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:108) - Server Port: 8080 INFO [2016-09-02 14:35:25,218] ({main} ZeppelinConfiguration.java[create]:109) - Context Path: / INFO [2016-09-02 14:35:25,224] ({main} ZeppelinConfiguration.java[create]:110) - Zeppelin Version: 0.7.0-SNAPSHOT ``` For Zeppelin class path and restart information, I am logging it from Shell script to log file as in below paragraph, So the format of logging is different . I know this is not per standards, Please let me know if you have any suggestions ``` Zeppelin is restarted ZEPPELIN_CLASSPATH: /home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/lib/*:/home/rajarajang/Workspace/stsWorksapce/zeppelin/*::/home/rajarajang/Workspace/stsWorksapce/zeppelin/conf:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-interpreter/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-zengine/target/classes:/home/rajarajang/Workspace/stsWorksapce/zeppelin/zeppelin-server/target/classes ``` Author: rajarajan-g <[email protected]> Closes apache#1399 from rajarajan-g/ZEPPELIN-1182 and squashes the following commits: f4f7f44 [rajarajan-g] updated as per review comments da69b16 [rajarajan-g] Added log statements for configuration
3 participants
What is this PR for?
PR is for logging configuration details of Zeppelin server.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1182
How should this be tested?
Please check the log if information on Server host, server path, context path, zeppelin version, class path is available in that file.
Screenshots (if appropriate)
Questions:
Note:
For configuration details such as zeppelin version, server host, port & context path , these are available as part of zeppelin configuration.
Logging information
For Zeppelin class path and restart information, I am logging it from Shell script to log file as in below paragraph, So the format of logging is different . I know this is not per standards, Please let me know if you have any suggestions