Merge to master#1
Merged
naitsirk-zz merged 1660 commits intonaitsirk-zz:masterfrom Mar 26, 2018
Merged
Conversation
* Change let to const * All converted and tests passing * removed unwanted file * Removed unwanted changes * Make default tslint prefer-const to true
* Misc changes * Adding change files.
Converting ResizeGroup SCSS to MergeStyles step 1 - file structure
* make onShouldVirtualize work for grouped list * rush changes
* Re-enable jsx-key * Use correct typings * Add npm change file
* Allow SwatchColorPickers to update focus on hover * ts lint fixes * update snapshot * rush change
…inset (#4006) * added support for aria-posinset and aria-setsize * added change file * updated snapshots
Convert ScrollablePane SCSS to MergeStyles
* Round 1 on converting to mergeStyles. - Move Dialog to DialogBase - Create Dialog.styles - Create new interfaces * npm run change output
* Updating type on Rating component. * Adding change file. * Updating snapshot.
* Fixing Dialog/Modal default props. * Adding change file.
* implement base file structure and styled() function * rush change
* implement base file structure and styled() function * rush change * Fix tests to recognize ImageBase * Updated maxSize for bundlesize
* Allow pointer events on diabled links used as buttons * Add change file * Fix wording in change file * Update snapshot
…utedStyle' on 'Window'" bug (#4039) * Checking this.refs.root for undefined before calling getComputedStyle(root) in _resizeContainer * adding change file * clarifying comment * Cancelling timers during componentWillUnmount to avoid using unmounted refs * updating comment * updated to use _async.setTimeout * updating comment
Convert Layer component to mergeStyles
Converting SCSS to MergeStyles step 2 - style conversion
* Enable no-internal-module lint rule * Add npm change file
…plit buttons (#4044) * added split button aria for contetual menu * add change files * added change file * added change file * added change file * aqdded change file * removed extra change files that appereard due to case error with branch names
* set input text size on textfield to 1 * Change file * Changed to min-width
* no message * no message * Adding public focus method * Change file * Fixing syntax and adding type * changing order to fix error
… aria-posinset value (#4004) * used correct indexing for focusable element idnex * fixed focus element index * add support for custom components to have their own lists * update comment * fixed the indexing to include moving to the next element * reverted, the original change is correct * resoled build problems
* Refactor to re-enable jsx-no-string-ref * Unneccesary publics * Update reference * Revert BaseFloatingPicker * Revert BaseFloatingPicker * Follow best practice * Remove unused ref * Tslint fix * Fix FocusTrapZone * Fix command bar * Update ContextualMenu.Directional.Example.tsx * Update DetailsList.Advanced.Example.tsx
* Add errorAs callback to Icon * change name * add change file * Fix Build Errors * Fix build errors * fix bundle error WITH PERMISSION. And extend base component and props * Make imageErrorAs type safe
* no message * no message * Added callback for menu dismiss and added example * Change file
* Updated toolkit links * Added change file
* Fixing a bug introduced by the DetailsHaeder. * Fix for detailsheader resizing. * Adding change files. * Fixing build error. * Removing unnecessary null. * Fixing import?
* Removing empty callout when tooltip content is empty * adding change file
…on activity card (#4299) * Add DocumentCardLogo * add changes file * add changes file * update * update on title to support secondary title used as text preview * update * update * remove focusZone fix that is not relevant to this change * removed unintentional changed files * update * change file * update
* A few more autobind removals * Npm change files
* Provide compact style for Activity timestamp * Update change output
* add neutral variant * changefile and export and cleanup
…pZone utilize it (#4306) * Introduced focusAsync for cheaper element focusing, and made FocusTrapZone utilize it * Added change files * Changed to minor change types
* fixing an issue with keydown. * Adding change file.
* Remove redundant tooltip * Add change file
…lling after folder navigation (#4336) * DetailsList: reset focusedItemIndex after setKey changes to fix scrolling after folder navigation * add change file * adding a test to cover the scenario * updating test and fixing a bug
…buttons and and spin boxes (#4222) * made spin button and base button menu option un-focusable * added spin button test * added split button contextual menu change * got rid of un-needed code * added change files * added abillitiy to not focus on primary button for split button, but only on the container * enter on focus on split button trigger primary action * added split button style for disabled * prevent opening submenu if item is disabled * tighten restrictions on opening split buttons to open with alt + down * refactored button name and fixed test * updated bundle size * changed on menu item click to bw able to take in a keyboard event * updated package json * fixed weird tabbing * changed way we structured the focus * added stop propagation * changed split button container key down to work with other buttons now * update bundle size * added correct split button container styles * removed unnecessary attribute * fixed focusing on menu button when primary button is disabled * added change to focus * added aria hidden * fixed span location and moved TODO * added support to focus on whole container in split button for contextual menus * added comment * fixed styling issues with buttons
* Add multiSelect for ComboBox * Unbreak a unit test * rush change * bug fixes * Merge from upstream and resolve local build issues * Fix merge styles * Fix pending background * Unbreak unit test cases * Fix the merge * Add controled multi-select in the example page to make sure onChanged cb works * Remove trailing white spaces * Fix bug: enter key will not trigger onChanged * Dummy change to trigger another build * refactor * Fix some minor bugs
* Fix types for componentRef * Add npm change files
* Add missing Signal icons * Update change output * Add SignalField mode parameter to control spacing
* Add multiSelect for ComboBox * Unbreak a unit test * rush change * bug fixes * Merge from upstream and resolve local build issues * Fix merge styles * Fix pending background * Unbreak unit test cases * Fix the merge * Add controled multi-select in the example page to make sure onChanged cb works * Remove trailing white spaces * Fix bug: enter key will not trigger onChanged * Dummy change to trigger another build * refactor * Fix some minor bugs * Update some comments for ComboBox * Minor bug fixes to the example page * rush change * Delete the old rush change file * Remove a trailing space
This reverts commit 2d181fe.
…itionally (#4350) * Fix bug in combo box where _selectedElement ref wasn't being set conditionally * Add rush change file * Use undefined instead of an empty string for the ref
* Reverting DetailsHeader maxWidth handling to previous behavior. * Adding change file.
* Updating to webpack 4.1.1 and ts-loader. * Adding change files. * fix * removing unneeded things. * removing unneeded var. * fix * Reverting ts-loader for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
(give an overview)
Focus areas to test
(optional)